Issue 4904049: Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4904049: Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Reinhold

Modified:
12 years, 7 months ago

Reviewers:
pkx166h, Trevor Daniels, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur

Patch Set 2 : Make slurs listen to inline-accidental #

Total comments: 5

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
A	input/regression/ambitus-slur.ly	View		1 chunk	+13 lines, -0 lines	5 comments	Download
M	lily/phrasing-slur-engraver.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	lily/slur-engraver.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Neil Puttock

http://codereview.appspot.com/4904049/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4904049/diff/1/scm/define-grobs.scm#newcode125 scm/define-grobs.scm:125: (avoid-slur . inside) I think it would make more ...

12 years, 8 months ago (2011-08-17 23:36:01 UTC) #1

Neil Puttock

LGTM. http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly File input/regression/ambitus-slur.ly (right): http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly#newcode3 input/regression/ambitus-slur.ly:3: texidoc = "Ambitus also works with slurs. prefer ...

12 years, 7 months ago (2011-09-05 15:55:30 UTC) #3

Trevor Daniels

12 years, 7 months ago (2011-09-07 07:41:14 UTC) #4

LGTM, but the regession test needs work

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly
File input/regression/ambitus-slur.ly (right):

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur...
input/regression/ambitus-slur.ly:3: texidoc = "Ambitus also works with slurs.
plus "so no misleading warnings are issued."

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur...
input/regression/ambitus-slur.ly:10: c'4( e')
On 2011/09/05 15:55:30, Neil Puttock wrote:
> need an accidentalled note here
It's not necessary to produce the unwanted error

Expand All Messages | Collapse All Messages