Issue 4902046: code review 4902046: template: delete old template code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4902046: code review 4902046: template: delete old template code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by r

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

template: delete old template code. It's already in old/template; make that build. Update a couple of references to point to the old template. They can be updated later. Update goplay to use exp/template.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r b7356f39774a https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2115 lines)			Patch
M	doc/codelab/wiki/final.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/final-noclosure.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/final-noerror.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/htmlify.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/index.html	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	doc/codelab/wiki/srcextract.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/wiki.html	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	doc/effective_go.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	misc/goplay/goplay.go	View		3 chunks	+5 lines, -13 lines	0 comments	Download
M	src/pkg/Makefile	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/pkg/old/template/Makefile	View		2 chunks	+2 lines, -2 lines	0 comments	Download
R	src/pkg/template/Makefile	View		1 chunk	+0 lines, -14 lines	0 comments	Download
R	src/pkg/template/doc.go	View		1 chunk	+0 lines, -91 lines	0 comments	Download
R	src/pkg/template/execute.go	View		1 chunk	+0 lines, -346 lines	0 comments	Download
R	src/pkg/template/format.go	View		1 chunk	+0 lines, -77 lines	0 comments	Download
R	src/pkg/template/parse.go	View		1 chunk	+0 lines, -743 lines	0 comments	Download
R	src/pkg/template/template_test.go	View		1 chunk	+0 lines, -804 lines	0 comments	Download
M	test/chan/select5.go	View		5 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-08-17 04:27:35 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/4902046/diff/1/doc/codelab/wiki/final-noerror.go File doc/codelab/wiki/final-noerror.go (right): http://codereview.appspot.com/4902046/diff/1/doc/codelab/wiki/final-noerror.go#newcode7 doc/codelab/wiki/final-noerror.go:7: "old/template" move up one line http://codereview.appspot.com/4902046/diff/1/doc/codelab/wiki/htmlify.go File doc/codelab/wiki/htmlify.go ...

14 years, 1 month ago (2011-08-17 04:32:39 UTC) #2

14 years, 1 month ago (2011-08-17 04:34:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e2fe0ef25bff ***

template: delete old template code.
It's already in old/template; make that build.
Update a couple of references to point to the old template.
They can be updated later.
Update goplay to use exp/template.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4902046

Expand All Messages | Collapse All Messages