Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2468)

Issue 4902045: Move some gpu headers from public include to src dir (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by bsalomon
Modified:
12 years, 8 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -911 lines) Patch
D gpu/include/GrGeometryBuffer.h View 1 chunk +0 lines, -101 lines 0 comments Download
D gpu/include/GrGpu.h View 1 chunk +0 lines, -560 lines 0 comments Download
D gpu/include/GrInOrderDrawBuffer.h View 1 chunk +0 lines, -188 lines 0 comments Download
D gpu/include/GrIndexBuffer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D gpu/include/GrVertexBuffer.h View 1 chunk +0 lines, -24 lines 0 comments Download
M gyp/gpu.gyp View 6 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
bsalomon
I dunno what's with upload.py but I've moved the headers to src not just deleted ...
12 years, 8 months ago (2011-08-16 12:16:58 UTC) #1
TomH
Assuming it's just a literal move, LGTM.
12 years, 8 months ago (2011-08-16 13:17:46 UTC) #2
bsalomon
12 years, 8 months ago (2011-08-16 15:48:18 UTC) #3
Closed with r2119 and r2120. (xcode's include path rules masked the fact that
SkGrTexturePixelRef.h was pulling GrGpu.g when it only needed GrTexture.h and
GrRenderTarget.h. Thus r2119 cause a build break fixed in r2120).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b