Issue 4888049: code review 4888049: rpc: make Server.Mutex unexported

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4888049: code review 4888049: rpc: make Server.Mutex unexported (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by dvyukov

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

rpc: make Server.Mutex unexported Currently it's possible to write: var s rpc.Server ... // reuse for my own purposes s.Lock() ... s.Unlock() which is seemingly not intended.

Patch Set 1 #

Patch Set 2 : diff -r 39c4fe186875 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 39c4fe186875 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/pkg/rpc/debug.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/pkg/rpc/server.go	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-16 08:20:58 UTC) #1

adg

13 years, 8 months ago (2011-08-16 08:35:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=245a17ebba26 ***

rpc: make Server.Mutex unexported
Currently it's possible to write:
var s rpc.Server
...
// reuse for my own purposes
s.Lock()
...
s.Unlock()
which is seemingly not intended.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4888049

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages