Issue 4888044: code review 4888044: runtime: fix pseudo-randomness on some selects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4888044: code review 4888044: runtime: fix pseudo-randomness on some selects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by niemeyer

Modified:
13 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev, dvyukov

Visibility:
Public.

Description

runtime: fix pseudo-randomness on some selects Fixes issue 2152.

Patch Set 1 #

Patch Set 2 : code review 4888044: runtime: fix pseudo-randomness on certain channel sends #

Patch Set 3 : diff -r 4dfd650363a2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4dfd650363a2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4dfd650363a2 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	src/pkg/runtime/chan.c	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/chan_test.go	View	1 2	2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-15 06:26:20 UTC) #1

dvyukov

> This only affects cases without queued items waiting on the channel... ... and sync ...

13 years, 8 months ago (2011-08-15 06:47:11 UTC) #2

niemeyer

*** Submitted as http://code.google.com/p/go/source/detail?r=39c4fe186875 *** runtime: fix pseudo-randomness on some selects Fixes issue 2152. R=golang-dev, ...

13 years, 8 months ago (2011-08-15 06:51:58 UTC) #3

LGTM

Expand All Messages | Collapse All Messages