Issue 4888041: code review 4888041: godoc: position URLs (containing file names) must be qu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4888041: code review 4888041: godoc: position URLs (containing file names) must be qu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by gri

Modified:
13 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

godoc: position URLs (containing file names) must be quoted and URL escaped Since the posLink_url also adds a non-URL attribute, the quoting and URL-escaping must happen inside posLink_url (otherwise the non-URL attribute becomes part or the URL portion of the tag.

Patch Set 1 #

Patch Set 2 : diff -r eca57094ac31 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eca57094ac31 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r eca57094ac31 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	lib/godoc/package.html	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/cmd/godoc/godoc.go	View	1	4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-12 23:11:31 UTC) #1

gri

13 years, 8 months ago (2011-08-12 23:28:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=de51e6f7dd3e ***

godoc: position URLs (containing file names) must be quoted and URL escaped

Since the posLink_url also adds a non-URL attribute, the quoting and 
URL-escaping
must happen inside posLink_url (otherwise the non-URL attribute becomes part or
the
URL portion of the tag.

R=r
CC=golang-dev
http://codereview.appspot.com/4888041

Expand All Messages | Collapse All Messages