code review 4887041: godoc: remove last vestiges of old template system

godoc: remove last vestiges of old template system

- rename template funcs for better consistency and
  sort them into groups of related functionality
- try to be more consistent with html vs url escaping

[gri, 2011-08-12 21:56:49]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-08-12 22:15:56]

LGTM

http://codereview.appspot.com/4887041/diff/7001/src/cmd/godoc/godoc.go
File src/cmd/godoc/godoc.go (right):

http://codereview.appspot.com/4887041/diff/7001/src/cmd/godoc/godoc.go#newcod...
src/cmd/godoc/godoc.go:432: return index.(*Index).Snippet(info.Lori()).Text
does the snippet need HTML escaping?

[gri, 2011-08-12 22:23:18]

http://codereview.appspot.com/4887041/diff/7001/src/cmd/godoc/godoc.go
File src/cmd/godoc/godoc.go (right):

http://codereview.appspot.com/4887041/diff/7001/src/cmd/godoc/godoc.go#newcod...
src/cmd/godoc/godoc.go:432: return index.(*Index).Snippet(info.Lori()).Text
On 2011/08/12 22:15:56, r wrote:
> does the snippet need HTML escaping?

no, see comment just before. clarified that comment.

[gri, 2011-08-12 22:23:44]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-08-12 22:34:47]

LGTM

[gri, 2011-08-12 22:43:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=eca57094ac31 ***

godoc: remove last vestiges of old template system

- rename template funcs for better consistency and
  sort them into groups of related functionality
- try to be more consistent with html vs url escaping

R=r
CC=golang-dev
http://codereview.appspot.com/4887041