Hack to fix 3D CSS printing.

Hack to fix 3D CSS printing.

BUG=chrome 82746

[Steve VanDeBogart, 2011-08-15 17:58:09]

Making setOrigin protected doesn't work because VectorPlatformDeviceSkia doesn't
inherit from SkPDFDevice, so can't call setOrigin on that class.  Would you
prefer to make it public or use this friend hack?  I've rebased this CL to undo
r2108.

[bungeman, 2011-08-15 18:13:52]

On 2011/08/15 17:58:09, Steve VanDeBogart wrote:
> Making setOrigin protected doesn't work because VectorPlatformDeviceSkia
doesn't
> inherit from SkPDFDevice, so can't call setOrigin on that class.  Would you
> prefer to make it public or use this friend hack?  I've rebased this CL to
undo
> r2108.

I think the idea was to do something like setMatrixClip, it's protected in
SkDevice, but public in SkPDFDevice (just a forward).

[Steve VanDeBogart, 2011-08-15 18:48:22]

On 2011/08/15 18:13:52, bungeman wrote:
> On 2011/08/15 17:58:09, Steve VanDeBogart wrote:
> > Making setOrigin protected doesn't work because VectorPlatformDeviceSkia
> doesn't
> > inherit from SkPDFDevice, so can't call setOrigin on that class.  Would you
> > prefer to make it public or use this friend hack?  I've rebased this CL to
> undo
> > r2108.
> 
> I think the idea was to do something like setMatrixClip, it's protected in
> SkDevice, but public in SkPDFDevice (just a forward).

Oops, forgot Mike was on vacation.  Thanks for looking at this.

I tried what you suggested, and it still won't work, I can't access getOrigin
either (it's protected, but in an SkDevice). I think we'd have to make getOrigin
public as well as forward setOrigin in SkPDFDevice.  Maybe cleaner to use the
friend hack?

[bungeman, 2011-08-15 20:10:43]

On 2011/08/15 18:48:22, Steve VanDeBogart wrote:
> On 2011/08/15 18:13:52, bungeman wrote:
> > On 2011/08/15 17:58:09, Steve VanDeBogart wrote:
> > > Making setOrigin protected doesn't work because VectorPlatformDeviceSkia
> > doesn't
> > > inherit from SkPDFDevice, so can't call setOrigin on that class.  Would
you
> > > prefer to make it public or use this friend hack?  I've rebased this CL to
> > undo
> > > r2108.
> > 
> > I think the idea was to do something like setMatrixClip, it's protected in
> > SkDevice, but public in SkPDFDevice (just a forward).
> 
> Oops, forgot Mike was on vacation.  Thanks for looking at this.
> 
> I tried what you suggested, and it still won't work, I can't access getOrigin
> either (it's protected, but in an SkDevice). I think we'd have to make
getOrigin
> public as well as forward setOrigin in SkPDFDevice.  Maybe cleaner to use the
> friend hack?

It seems that we should probably just make VectorPlatformDeviceSkia a friend of
SkPDFDevice (instead of SkDevice). And while we're at it, remove the
setMatrixClip wrapper in SkPDFDevice.

[Steve VanDeBogart, 2011-08-15 20:48:42]

On 2011/08/15 20:10:43, bungeman wrote:
> On 2011/08/15 18:48:22, Steve VanDeBogart wrote:
> > On 2011/08/15 18:13:52, bungeman wrote:
> > > On 2011/08/15 17:58:09, Steve VanDeBogart wrote:
> > > > Making setOrigin protected doesn't work because VectorPlatformDeviceSkia
> > > doesn't
> > > > inherit from SkPDFDevice, so can't call setOrigin on that class.  Would
> you
> > > > prefer to make it public or use this friend hack?  I've rebased this CL
to
> > > undo
> > > > r2108.
> > > 
> > > I think the idea was to do something like setMatrixClip, it's protected in
> > > SkDevice, but public in SkPDFDevice (just a forward).
> > 
> > Oops, forgot Mike was on vacation.  Thanks for looking at this.
> > 
> > I tried what you suggested, and it still won't work, I can't access
getOrigin

Oops, looking at it again, I used the wrong variable, this will work.  Change in
http://codereview.appspot.com/4888048

> > either (it's protected, but in an SkDevice). I think we'd have to make
> getOrigin
> > public as well as forward setOrigin in SkPDFDevice.  Maybe cleaner to use
the
> > friend hack?
> 
> It seems that we should probably just make VectorPlatformDeviceSkia a friend
of
> SkPDFDevice (instead of SkDevice). And while we're at it, remove
> the setMatrixClip wrapper in SkPDFDevice.

SkPDFDevice doesn't use setMatrixClip...