Issue 4888048: Make SkPDFDevice::setOrigin accessible to Chrome's VectorPlatformDeviceSkia.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4888048: Make SkPDFDevice::setOrigin accessible to Chrome's VectorPlatformDeviceSkia. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by Steve VanDeBogart

Modified:
12 years, 10 months ago

Reviewers:
bungeman, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Make SkPDFDevice::setOrigin accessible to Chrome's VectorPlatformDeviceSkia. BUG=chrome 82746 Committed: http://code.google.com/p/skia/source/detail?r=2116

Patch Set 1 #

Total comments: 2

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View		1 chunk	+5 lines, -0 lines	2 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

LGTM Comment to clarify my statement http://codereview.appspot.com/4872042/#msg5 . http://codereview.appspot.com/4888048/diff/1/include/pdf/SkPDFDevice.h File include/pdf/SkPDFDevice.h (right): http://codereview.appspot.com/4888048/diff/1/include/pdf/SkPDFDevice.h#newcode73 include/pdf/SkPDFDevice.h:73: virtual ...

12 years, 10 months ago (2011-08-15 21:01:21 UTC) #2

Steve VanDeBogart

12 years, 10 months ago (2011-08-15 21:29:01 UTC) #3

http://codereview.appspot.com/4888048/diff/1/include/pdf/SkPDFDevice.h
File include/pdf/SkPDFDevice.h (right):

http://codereview.appspot.com/4888048/diff/1/include/pdf/SkPDFDevice.h#newcode73
include/pdf/SkPDFDevice.h:73: virtual void setMatrixClip(const SkMatrix& m,
const SkRegion& r,
On 2011/08/15 21:01:21, bungeman wrote:
> This is here for the same reason setOrigin is moving here. Should move this
down
> with setOrigin and use INHERITED as well.

Ohh indeed.  I'll do that in a follow up CL because I want to minimize what
needs to be merged.

Expand All Messages | Collapse All Messages