Issue 4869042: code review 4869042: exp/template: find the String method by taking the addr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4869042: code review 4869042: exp/template: find the String method by taking the addr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by r

Modified:
14 years, 2 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

exp/template: find the String method by taking the address if we need to. Also simplify nil handling in printing.

Patch Set 2 : diff -r 2ee7aad6fa4e https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
	M	src/pkg/exp/template/exec.go	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
	M	src/pkg/exp/template/exec_test.go	View		3 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-08-11 04:29:58 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/4869042/diff/1/src/pkg/exp/template/exec.go File src/pkg/exp/template/exec.go (right): http://codereview.appspot.com/4869042/diff/1/src/pkg/exp/template/exec.go#newcode630 src/pkg/exp/template/exec.go:630: break no need for this break now.

14 years, 2 months ago (2011-08-11 04:32:06 UTC) #2

14 years, 2 months ago (2011-08-11 04:37:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0d457aeccc91 ***

exp/template: find the String method by taking the address if we need to.
Also simplify nil handling in printing.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4869042

Expand All Messages | Collapse All Messages