Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4643)

Issue 4868046: Fixes figuredBassCenterContinuations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Bertrand Bordage
Modified:
12 years, 7 months ago
Reviewers:
pkx166h, Reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes figuredBassCenterContinuations.

Patch Set 1 #

Patch Set 2 : Removes the condition. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M lily/figured-bass-engraver.cc View 1 1 chunk +8 lines, -11 lines 1 comment Download

Messages

Total messages: 4
Bertrand Bordage
figuredBassCenterContinuations fails to merge continuation lines on if a figure is composed of three or ...
12 years, 8 months ago (2011-08-12 12:24:01 UTC) #1
Reinhold
LGTM. That check has been there since time immemorial. I have sometimes wondered, too, but ...
12 years, 8 months ago (2011-08-12 13:06:07 UTC) #2
Bertrand Bordage
This was introduced in one of Han-Wen's commits : 7d7d33f3f1c6c45aaf3fd1e5c68b0b75a1be248d At that time there was ...
12 years, 8 months ago (2011-08-12 13:59:31 UTC) #3
pkx166h
12 years, 7 months ago (2011-08-28 10:13:46 UTC) #4
passes make and reg tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b