Issue 4861041: Make a more descriptive warning when comparing NULL with non-pointer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4861041: Make a more descriptive warning when comparing NULL with non-pointer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rtrieu

Modified:
12 years, 9 months ago

Reviewers:
chandlerc

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	include/clang/Basic/DiagnosticSemaKinds.td	View	1 chunk	+4 lines, -0 lines	2 comments	Download
M	lib/Sema/SemaExpr.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	test/SemaCXX/null_in_arithmetic_ops.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

chandlerc

http://codereview.appspot.com/4861041/diff/1/include/clang/Basic/DiagnosticSemaKinds.td File include/clang/Basic/DiagnosticSemaKinds.td (right): http://codereview.appspot.com/4861041/diff/1/include/clang/Basic/DiagnosticSemaKinds.td#newcode3168 include/clang/Basic/DiagnosticSemaKinds.td:3168: "%select{(%1 and NULL)|(NULL and %1)}0">, Why repeat the NULL ...

12 years, 9 months ago (2011-08-11 01:32:13 UTC) #1

rtrieu

12 years, 9 months ago (2011-08-11 01:44:30 UTC) #2

http://codereview.appspot.com/4861041/diff/1/include/clang/Basic/DiagnosticSe...
File include/clang/Basic/DiagnosticSemaKinds.td (right):

http://codereview.appspot.com/4861041/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:3168: "%select{(%1 and NULL)|(NULL
and %1)}0">,
On 2011/08/11 01:32:14, chandlerc wrote:
> Why repeat the NULL here? Maybe just "... between NULL and non-pointer %1'.
Also
> I wonder if we want to spell NULL the way the user did (NULL vs. (void*)0 vs.
> nullptr).

The NULL is repeated since many other warnings on binary operations will have
('type1' and 'type2') so this is to be consistent with them.

This warning checks for a GNUNullExpr, so it won't trigger on (void*)0 or
nullptr.  In those cases, a separate error will be emitted.  I believe it will
trigger on __null, but I don't think that is commonly used.

Expand All Messages | Collapse All Messages