Issue 4839061: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (Closed)
|
Created:
12 years, 8 months ago by pkx166h Modified:
12 years, 6 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionDoc: NR remove 5.1.7
Tracker issue 1812
Removed 5.1.7 as it was felt that this was already explaind in 5.1.6
the use of \accepts and \denies is now only required when
creating new contexts.
Patch Set 1 #Patch Set 2 : Need some guidance by those that understand this more than I #
Total comments: 8
Patch Set 3 : With Trevor D's suggestions. Thanks Trevor. #
Total comments: 1
Patch Set 4 : Added @lilypond example #
Total comments: 14
MessagesTotal messages: 9
James My suggestion was to remove the *material* in 5.1.7 and replace it with material from 5.4.3, removing 5.4.3 as a section. The reference at the end of the material from 5.4.3 will need to be removed. Also, following Neil's reminder, we need to expand the documentation of the use of \accepts in 5.1.7 too, using his neat example. Trevor
Sign in to reply to this message.
On 2011/08/10 22:32:13, Trevor Daniels wrote: > James > My suggestion was to remove the *material* in 5.1.7 and replace it with material > from 5.4.3, removing 5.4.3 as a section. The reference at the end of the > material from 5.4.3 will need to be removed. Also, following Neil's reminder, > we need to expand the documentation of the use of \accepts in 5.1.7 too, using > his neat example. > Trevor I've done an initial patch and know it still needs more work but I need some guidance and suggestions as this is something I know little about technically
Sign in to reply to this message.
James Looks pretty good. I've made a couple of suggested additions. Could you please make a new patch with these changes in, and then I'll give it a more careful check over. Trevor http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:935: @cindex contexts, layout order @funindex \accepts @funindex \denies http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:954: To places chord names on a stave e.g., Replace the previous two paras with: The @qq{accepts} list of a context can be changed with the @code{\accepts} and @code{\denies} commands. @code{\accepts} adds a context to the @qq{accepts} list and @code{\denies} removes a context from the list. For example, it would not normally be desirable for chord names to be nested within a @{Staff} context, so the @code{ChordNames} context is not included by default in the @qq{accepts} list of the @code{Staff} context, but if this were to be required it can be done: http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:964: Add here: @code{\denies} is mainly used when a new context is being based on another, but the required nesting differs. For example, the @code{VaticanaStaff} context is based on the @code{Staff} context, but with the @code{VaticanaVoice} context substituted for the @code{Voice} context in the @qq{accepts} list. http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:967: @rprogram{An extra staff appears}. Add: Installed Files: @file{ly/engraver-init.ly}.
Sign in to reply to this message.
New Patch set loaded with Trevor's suggestions. James http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:935: @cindex contexts, layout order On 2011/09/24 22:17:30, Trevor Daniels wrote: > @funindex \accepts > @funindex \denies Done. http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:954: To places chord names on a stave e.g., On 2011/09/24 22:17:30, Trevor Daniels wrote: > Replace the previous two paras with: > ... Thank you! Done. http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:964: On 2011/09/24 22:17:30, Trevor Daniels wrote: > Add here: > ... Again, thank you. Done. http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:967: @rprogram{An extra staff appears}. On 2011/09/24 22:17:30, Trevor Daniels wrote: > Add: > > Installed Files: > @file{ly/engraver-init.ly}. Done.
Sign in to reply to this message.
http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changi... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changi... Documentation/notation/changing-defaults.itely:961: @example could this be a @lilypond instead?
Sign in to reply to this message.
On 2011/09/27 04:35:56, Graham Percival wrote: > http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changi... > File Documentation/notation/changing-defaults.itely (right): > > http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changi... > Documentation/notation/changing-defaults.itely:961: @example > could this be a @lilypond instead? Done. I did a before-and-after to show the users who might not be familiar with what chords normally look like (I can never remember if they go above or below by default whenever I use them) and used two @lilyponds, (one without [verbatim] to save the space) so this is clearer.
Sign in to reply to this message.
A few comments, but otherwise LGTM. If you agree the changes and it compiles please push. Trevor http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:950: contain it. This can give rise to unexpected new staves or scores. I think this might be better placed at the end of this section. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:961: @lilypond[quote] Hmm. I think we do need verbatim here too to make it clear what is being demonstrated. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:963: \new Staff { c' d' e' f' newline and indent http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:964: \chords { d1:m7 b1:min7.5- } indent http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:971: \new Staff { c' d' e' f' newline and indent http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:972: \chords { d1:m7 b1:min7.5- } indent
Sign in to reply to this message.
I agree with everything Trevor said, including pushing after you've changed it and it compiles. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:961: @lilypond[quote] On 2011/10/01 20:27:17, Trevor Daniels wrote: > Hmm. I think we do need verbatim here too to make it clear what is being > demonstrated. agreed. It's a short example; there's no need to override the "you must use verbatim unless it makes things obviously worse" rule.
Sign in to reply to this message.
Thanks Trevor and Graham. I also had to change an @ref in vocal.itely because the node name changed. Checked it all compiled. commit 32c862967d559ab512cd96e3321a2c8dabe724ca http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:950: contain it. This can give rise to unexpected new staves or scores. On 2011/10/01 20:27:17, Trevor Daniels wrote: > I think this might be better placed at the end of this section. Done. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:961: @lilypond[quote] On 2011/10/01 20:27:17, Trevor Daniels wrote: > Hmm. I think we do need verbatim here too to make it clear what is being > demonstrated. Done. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:961: @lilypond[quote] On 2011/10/01 20:27:17, Trevor Daniels wrote: > Hmm. I think we do need verbatim here too to make it clear what is being > demonstrated. Done. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:963: \new Staff { c' d' e' f' On 2011/10/01 20:27:17, Trevor Daniels wrote: > newline and indent Done. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:964: \chords { d1:m7 b1:min7.5- } On 2011/10/01 20:27:17, Trevor Daniels wrote: > indent Done. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:971: \new Staff { c' d' e' f' On 2011/10/01 20:27:17, Trevor Daniels wrote: > newline and indent Done. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/chang... Documentation/notation/changing-defaults.itely:972: \chords { d1:m7 b1:min7.5- } On 2011/10/01 20:27:17, Trevor Daniels wrote: > indent Done.
Sign in to reply to this message.
|
