Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 4838053: code review 4838053: uuid: source re-organization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by borman
Modified:
12 years, 9 months ago
Reviewers:
CC:
rsc, borman
Visibility:
Public.

Description

uuid: source re-organization Move source to uuid subdirectory. Add in coderviewability.

Patch Set 1 #

Patch Set 2 : diff -r 3b7f8ceb731f https://borman%40google.com@code.google.com/p/go-uuid/ #

Patch Set 3 : diff -r 3b7f8ceb731f https://borman%40google.com@code.google.com/p/go-uuid/ #

Total comments: 2

Patch Set 4 : diff -r 3b7f8ceb731f https://go-uuid.googlecode.com/hg #

Patch Set 5 : diff -r 3b7f8ceb731f https://go-uuid.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4332 lines, -1093 lines) Patch
A CONTRIBUTORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
R dce.go View 1 1 chunk +0 lines, -95 lines 0 comments Download
R hash.go View 1 1 chunk +0 lines, -71 lines 0 comments Download
A lib/codereview/codereview.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
A lib/codereview/codereview.py View 1 1 chunk +3291 lines, -0 lines 0 comments Download
R node.go View 1 1 chunk +0 lines, -115 lines 0 comments Download
R time.go View 1 1 chunk +0 lines, -124 lines 0 comments Download
R util.go View 1 1 chunk +0 lines, -54 lines 0 comments Download
R uuid.go View 1 1 chunk +0 lines, -176 lines 0 comments Download
A uuid/LICENSE View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A uuid/Makefile View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A uuid/dce.go View 1 2 3 1 chunk +84 lines, -0 lines 0 comments Download
A uuid/hash.go View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A uuid/node.go View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
A uuid/time.go View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
A uuid/util.go View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A uuid/uuid.go View 1 2 3 1 chunk +165 lines, -0 lines 0 comments Download
A uuid/uuid_test.go View 1 2 3 1 chunk +359 lines, -0 lines 0 comments Download
A uuid/version1.go View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A uuid/version4.go View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
R uuid_test.go View 1 1 chunk +0 lines, -370 lines 0 comments Download
R version1.go View 1 1 chunk +0 lines, -52 lines 0 comments Download
R version4.go View 1 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 4
borman
Hello rsc@google.com (cc: borman@google.com), I'd like you to review this change to https://borman%40google.com@code.google.com/p/go-uuid/
12 years, 9 months ago (2011-08-08 21:16:18 UTC) #1
rsc1
> I'd like you to review this change to > https://borman%40google.com@code.google.com/p/go-uuid/ i'd edit your ...go-uuid/.hg/hgrc ...
12 years, 9 months ago (2011-08-08 21:27:33 UTC) #2
rsc
LGTM http://codereview.appspot.com/4838053/diff/4001/CONTRIBUTORS File CONTRIBUTORS (right): http://codereview.appspot.com/4838053/diff/4001/CONTRIBUTORS#newcode2 CONTRIBUTORS:2: Russ Cox <rsc@golang.org> can delete me http://codereview.appspot.com/4838053/diff/4001/uuid/Makefile File ...
12 years, 9 months ago (2011-08-08 21:30:56 UTC) #3
borman
12 years, 9 months ago (2011-08-08 21:35:05 UTC) #4
*** Submitted as http://code.google.com/p/go-uuid/source/detail?r=4bd5ace0179d
***

uuid: source re-organization

Move source to uuid subdirectory.
Add in coderviewability.

R=rsc
CC=borman
http://codereview.appspot.com/4838053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b