Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6386)

Issue 4837047: Lets auto numbering of footnotes kick in from commands alone. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by MikeSol
Modified:
12 years, 8 months ago
Reviewers:
pkx166h, mikesol, Reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Lets auto numbering of footnotes kick in from commands alone. Gets rid of footnote-auto-numbering in the paper block. For now, numbers that are not used are skiped.

Patch Set 1 #

Patch Set 2 : Fixes text property in FootnoteEvent for autoFootnoteGrob #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -75 lines) Patch
M input/regression/footnote.ly View 1 chunk +0 lines, -4 lines 0 comments Download
M input/regression/footnote-auto-numbering.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/footnote-auto-numbering-page-reset.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/footnote-break-visibility.ly View 1 chunk +0 lines, -4 lines 0 comments Download
M input/regression/footnote-footer-padding.ly View 1 chunk +0 lines, -4 lines 0 comments Download
M input/regression/footnote-spanner.ly View 1 chunk +0 lines, -1 line 0 comments Download
M lily/constrained-breaking.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/page-breaking.cc View 1 chunk +1 line, -3 lines 0 comments Download
M lily/page-layout-problem.cc View 4 chunks +42 lines, -38 lines 1 comment Download
M ly/music-functions-init.ly View 1 4 chunks +11 lines, -6 lines 0 comments Download
M ly/paper-defaults-init.ly View 1 chunk +0 lines, -1 line 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -0 lines 1 comment Download
M scm/define-grobs.scm View 2 chunks +2 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 2 chunks +28 lines, -4 lines 0 comments Download
M scm/define-music-properties.scm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
MikeSol
From Reinhold's suggestion. Cheers, MS
12 years, 9 months ago (2011-08-01 21:59:06 UTC) #1
MikeSol
On 2011/08/01 21:59:06, MikeSol wrote: > From Reinhold's suggestion. > > Cheers, > MS Most ...
12 years, 9 months ago (2011-08-01 22:04:48 UTC) #2
Reinhold
That's exactly as I envisioned it. Numbering works fine, except in staff systems. the example ...
12 years, 8 months ago (2011-08-10 21:31:38 UTC) #3
pkx166h
passes make and reg tests.
12 years, 8 months ago (2011-08-28 10:44:54 UTC) #4
mikesol_ufl.edu
12 years, 8 months ago (2011-08-29 15:13:41 UTC) #5
On Aug 28, 2011, at 12:44 PM, pkx166h@gmail.com wrote:

> passes make and reg tests.
> 
> http://codereview.appspot.com/4837047/


Pushed as 181366ec566a338c265ff4960724202d0d55ef79.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b