Issue 4836045: code review 4836045: cmd/*/*.c: Compile under Plan 9.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4836045: code review 4836045: cmd//.c: Compile under Plan 9. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by lucio

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/*/*.c: Compile under Plan 9. src/cmd/5c/reg.c: . Added USED() attribute. src/cmd/6c/cgen.c: . Revised code around "REGARG" to resemble use in "8c" and consequently remove a warning. src/cmd/asm.c: . Added USED() attributes. . Removed an unnecessary assignment.

Patch Set 1 #

Patch Set 2 : diff -r b7a6a0b381b7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7a6a0b381b7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 40194af9cb12 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	src/cmd/5c/reg.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6c/cgen.c	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-31 19:44:02 UTC) #1

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), Please take another look.

13 years, 8 months ago (2011-08-09 05:00:14 UTC) #2

rsc

13 years, 8 months ago (2011-08-16 18:22:11 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=2e82027ba494 ***

5c, 6c, 6l: fix Plan 9 build warnings

src/cmd/5c/reg.c:
. Added USED() attribute.

src/cmd/6c/cgen.c:
. Revised code around "REGARG" to resemble use in "8c" and
  consequently remove a warning.

src/cmd/6l/asm.c:
. Added USED() attributes.
. Removed an unnecessary assignment.

R=golang-dev
CC=golang-dev, rsc
http://codereview.appspot.com/4836045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages