Issue 4832063: Consolidate shared code between Check (Addition, Subtraction, IncrementDecrement) Operands()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4832063: Consolidate shared code between Check (Addition, Subtraction, IncrementDecrement) Operands() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rtrieu

Modified:
12 years, 8 months ago

Reviewers:
Sean Hunt

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Description

Uploaded at revision 138975.

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -21 lines)			Patch
	M	lib/Sema/SemaExpr.cpp	View		5 chunks	+29 lines, -21 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Sean Hunt

12 years, 9 months ago (2011-08-09 22:59:13 UTC) #1

By contrast, I think these ones look more fine (I'm a bit questioning of
DiagnostPointerIncompatibility). Probably it's best to check with Doug about
whether these are good in principle. The actual patch looks good.

Expand All Messages | Collapse All Messages