Issue 4832058: code review 4832058: uuid: clean to use more idiomatic names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4832058: code review 4832058: uuid: clean to use more idiomatic names (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by borman

Modified:
12 years, 9 months ago

Reviewers:

CC:
rcs_google.com, borman

Visibility:
Public.

Description

uuid: clean to use more idiomatic names Convert constants to more Go like names (e.g,. DOMAIN_PERSON -> Person) Use the hash.Hash interface instead of our own.

Patch Set 1 #

Patch Set 2 : diff -r 361dcc2de674 https://go-uuid.googlecode.com/hg #

Patch Set 3 : diff -r 361dcc2de674 https://go-uuid.googlecode.com/hg #

Patch Set 4 : diff -r 361dcc2de674 https://go-uuid.googlecode.com/hg #

Patch Set 5 : diff -r cef88f1a287d https://go-uuid.googlecode.com/hg #

Patch Set 6 : diff -r cef88f1a287d https://go-uuid.googlecode.com/hg #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -82 lines)			Patch
M	uuid/dce.go	View	1 2 3	3 chunks	+18 lines, -18 lines	0 comments	Download
M	uuid/hash.go	View	1	2 chunks	+7 lines, -14 lines	0 comments	Download
M	uuid/uuid.go	View	1 2 3	5 chunks	+21 lines, -23 lines	0 comments	Download
M	uuid/uuid_test.go	View	1 2 3	7 chunks	+56 lines, -27 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

borman

Hello rcs@google.com (cc: borman@google.com), I'd like you to review this change to https://go-uuid.googlecode.com/hg

12 years, 9 months ago (2011-08-08 21:53:38 UTC) #1

borman

On 2011/08/08 21:53:38, borman wrote: > Hello mailto:rcs@google.com (cc: mailto:borman@google.com), > > I'd like you ...

12 years, 9 months ago (2011-08-09 04:10:35 UTC) #2

borman

12 years, 9 months ago (2011-08-10 00:21:02 UTC) #3

*** Submitted as http://code.google.com/p/go-uuid/source/detail?r=b1a0f047c0cb
***

uuid: clean to use more idiomatic names

Convert constants to more Go like names (e.g,. DOMAIN_PERSON -> Person)
Use the hash.Hash interface instead of our own.

R=rcs
CC=borman
http://codereview.appspot.com/4832058

Expand All Messages | Collapse All Messages