Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 4830051: code review 4830051: acme: scrolling fixes + new home/end (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
mccoyst
CC:
r, mccoyst_gmail.com
Visibility:
Public.

Description

acme: scrolling fixes + new home/end Home and End previously navigated between two different window locations: the top and the bottom of the text. Now they include a third waypoint: the location where typing last happened. Thus, in a win window, typing ls -l <home> scrolls to the beginning of the ls -l output. A second <home> continues to the top of the file. Makes Send scroll always, along with writes by external programs to +Errors.

Patch Set 1 #

Patch Set 2 : code review 4830051: acme: scrolling fixes + new home/end #

Patch Set 3 : diff -r 98196ecda9f9 rsc/plan9port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M src/cmd/acme/dat.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/acme/exec.c View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/acme/text.c View 1 2 8 chunks +19 lines, -2 lines 0 comments Download
M src/cmd/acme/xfid.c View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: mccoyst), I'd like you to review this change.
13 years, 5 months ago (2011-08-02 02:32:33 UTC) #1
r
LGTM but i wonder if q1 wouldn't be a better idea. if i send a ...
13 years, 5 months ago (2011-08-02 03:29:34 UTC) #2
rsc
Although it's named iq0, it behaves the way you describe.
13 years, 5 months ago (2011-08-02 11:31:49 UTC) #3
rsc
*** Submitted as 00a8dbea691f *** acme: scrolling fixes + new home/end Home and End previously ...
13 years, 5 months ago (2011-08-02 11:44:17 UTC) #4
mccoyst
13 years, 5 months ago (2011-08-02 14:32:56 UTC) #5
This works fantastically. Thanks, guys!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b