Issue 4826041: code review 4826041: cgo: fixes callback for windows amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4826041: code review 4826041: cgo: fixes callback for windows amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by vcc

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r c162ec4be385 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c162ec4be385 http://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r dab583e3969f http://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -5 lines)			Patch
M	misc/cgo/life/Makefile	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/amd64/asm.s	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/cgo/amd64.S	View	1	3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

vcc

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/

12 years, 9 months ago (2011-07-25 08:34:40 UTC) #1

rsc

Except for the change to c-life.c I'm happy. http://codereview.appspot.com/4826041/diff/4001/misc/cgo/life/c-life.c File misc/cgo/life/c-life.c (right): http://codereview.appspot.com/4826041/diff/4001/misc/cgo/life/c-life.c#newcode5 misc/cgo/life/c-life.c:5: #ifdef ...

12 years, 8 months ago (2011-08-16 20:04:29 UTC) #2

vcc

PTAL http://codereview.appspot.com/4826041/diff/4001/misc/cgo/life/c-life.c File misc/cgo/life/c-life.c (right): http://codereview.appspot.com/4826041/diff/4001/misc/cgo/life/c-life.c#newcode5 misc/cgo/life/c-life.c:5: #ifdef _WIN64 On 2011/08/16 20:04:29, rsc wrote: > ...

12 years, 8 months ago (2011-08-19 06:25:02 UTC) #3

rsc

12 years, 8 months ago (2011-08-26 20:43:41 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=13dd6cb7c8b3 ***

cgo: fixes callback for windows amd64

R=rsc
CC=golang-dev
http://codereview.appspot.com/4826041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages