Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1604)

Issue 4825051: Removes closeness-factor from the Slur details list. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by MikeSol
Modified:
12 years, 5 months ago
Reviewers:
pkx166h, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Removes closeness-factor from the Slur details list.

Patch Set 1 #

Patch Set 2 : Rebase against current master. #

Patch Set 3 : Other small fixes #

Patch Set 4 : Fixes indentation #

Patch Set 5 : more rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M lily/include/slur-score-parameters.hh View 1 1 chunk +0 lines, -1 line 0 comments Download
M lily/slur.cc View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M lily/slur-configuration.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M lily/slur-score-parameters.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M scm/layout-slur.scm View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7
MikeSol
This passes regtests without any change in the visual output. After wading through slur-configuration.cc, I ...
12 years, 8 months ago (2011-07-27 11:09:21 UTC) #1
MikeSol
Hey all, I haven't heard anything on this for a bit and wanted to know ...
12 years, 6 months ago (2011-10-03 03:58:07 UTC) #2
MikeSol
Hey all, I haven't heard anything on this for a bit and wanted to know ...
12 years, 6 months ago (2011-10-03 03:58:08 UTC) #3
hanwenn
LGTM I can see the reasoning behind the parameter, but readily believe other mechanisms already ...
12 years, 6 months ago (2011-10-03 05:01:54 UTC) #4
pkx166h
added as http://code.google.com/p/lilypond/issues/detail?id=1953
12 years, 6 months ago (2011-10-03 07:56:48 UTC) #5
pkx166h
Mike this patch no longer applies to current tree. I get failed hunks.
12 years, 5 months ago (2011-10-04 05:45:30 UTC) #6
pkx166h
12 years, 5 months ago (2011-10-08 05:08:02 UTC) #7
Passes make and make check looks fine too.

Graphviz.log does show up (and as I don't know what it means I'll paste it here
anyway just in case ...)

@@ -15,13 +15,13 @@
 rankdir="LR"
 node [shape=rectangle]
 41 [label="caching Stem.stencil\n# -> #"]
-40 [label="caching VerticalAxisGroup.stencil\n# -> #f"]
-39 [label="caching LedgerLineSpanner.stencil\n# -> #"]
-38 [label="caching StaffSymbol.stencil\n# -> #"]
-37 [label="caching Stem.Y-extent\n# -> (-2.812186 . 0.5)"]
-36 [label="caching Stem.length\n# -> 6.624372"]
-35 [label="caching Stem.stem-begin-position\n# -> -5.624372"]
-34 [label="caching Stem.Y-offset\n# -> 0.0"]
+40 [label="caching LedgerLineSpanner.stencil\n# -> #"]
+39 [label="caching VerticalAxisGroup.stencil\n# -> #f"]
+38 [label="caching Stem.Y-extent\n# -> (-2.812186 . 0.5)"]
+37 [label="caching Stem.length\n# -> 6.624372"]
+36 [label="caching Stem.stem-begin-position\n# -> -5.624372"]
+35 [label="caching Stem.Y-offset\n# -> 0.0"]
+34 [label="caching StaffSymbol.stencil\n# -> #"]
 33
[label="Stem\n/home/jlowe/lilypond-git/lily/grob.cc:341\npure-Y-offset-in-progress
<- #t"]
 32 [label="caching TimeSignature.stencil\n# -> #"]
 31 [label="caching Stem.X-extent\n# -> (-0.065 . 0.065)"]
@@ -56,11 +56,11 @@
 2 [label="NoteHead\n/home/jlowe/lilypond-git/lily/engraver.cc:60\ncause <- # 41
+38 -> 41
+37 -> 38
 36 -> 37
 35 -> 36
-34 -> 35
-33 -> 34
+33 -> 35
 31 -> 33
 30 -> 31
 29 -> 30

----snip--

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b