Issue 4825043: code review 4825043: runtime: fix compilation of send select cases

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4825043: code review 4825043: runtime: fix compilation of send select cases (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by dvyukov

Modified:
13 years, 8 months ago

Reviewers:

CC:
albert.strasheim, rsc, golang-dev

Visibility:
Public.

Description

runtime: fix compilation of send select cases Fixes issue 2102.

Patch Set 2 : diff -r c162ec4be385 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c162ec4be385 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r c162ec4be385 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c162ec4be385 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/select.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/subr.c	View	1 2 3	2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/chan_test.go	View	1 2 3	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-25 15:41:53 UTC) #1

albert.strasheim

On 2011/07/25 15:41:53, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

13 years, 8 months ago (2011-07-25 15:47:42 UTC) #2

rsc

http://codereview.appspot.com/4825043/diff/6002/src/cmd/gc/subr.c File src/cmd/gc/subr.c (right): http://codereview.appspot.com/4825043/diff/6002/src/cmd/gc/subr.c#newcode2761 src/cmd/gc/subr.c:2761: * return n in a local variable if it ...

13 years, 8 months ago (2011-07-25 15:59:23 UTC) #3

dvyukov

Hello fullung@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-07-25 16:07:15 UTC) #4

rsc

13 years, 8 months ago (2011-07-25 16:25:40 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=73c6d7942073 ***

runtime: fix compilation of send select cases

Fixes issue 2102.

R=fullung, rsc
CC=golang-dev
http://codereview.appspot.com/4825043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages