Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 4824041: code review 4824041: lib9: use $PWD in getwd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by rsc
Modified:
13 years, 9 months ago
Reviewers:
CC:
iant, r, mattn, golang-dev
Visibility:
Public.

Description

lib9: use $PWD in getwd This makes the full file paths recorded by 6g prefer $PWD over the actual directory name (relevant when $PWD gets to the current directory via symlinks). It's what everyone else does, and what people expect.

Patch Set 1 #

Patch Set 2 : diff -r b23c59e6b442 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b23c59e6b442 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d951e2a4e1bb https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/lib9/getwd.c View 1 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello iant, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 9 months ago (2011-07-22 05:15:00 UTC) #1
r
LGTM
13 years, 9 months ago (2011-07-22 05:20:31 UTC) #2
iant
LGTM Thanks.
13 years, 9 months ago (2011-07-22 05:40:14 UTC) #3
mattn
Is this work on windows? Then, not good. On 2011/07/22 05:15:00, rsc wrote: > Hello ...
13 years, 9 months ago (2011-07-22 05:49:15 UTC) #4
rsc
On Fri, Jul 22, 2011 at 01:49, <mattn.jp@gmail.com> wrote: > Is this work on windows? ...
13 years, 9 months ago (2011-07-23 01:21:00 UTC) #5
rsc
13 years, 9 months ago (2011-07-23 01:21:19 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=0b4b62c02a57 ***

lib9: use $PWD in getwd

This makes the full file paths recorded by 6g
prefer $PWD over the actual directory name
(relevant when $PWD gets to the current directory
via symlinks).  It's what everyone else does, and
what people expect.

R=iant, r, mattn.jp
CC=golang-dev
http://codereview.appspot.com/4824041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b