Issue 4822046: Treats multi measure rest staff position like rest staff position.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4822046: Treats multi measure rest staff position like rest staff position. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by MikeSol

Modified:
12 years, 8 months ago

Reviewers:
pkx166h, Neil Puttock, Trevor Daniels, Reinhold

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Treats multi measure rest staff position like rest staff position.

Patch Set 2 : Adds regtest. #

Total comments: 3

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
A	input/regression/multi-measure-rest-staff-position.ly	View	1	1 chunk	+12 lines, -0 lines	2 comments	Download
M	lily/multi-measure-rest.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
M	scm/define-grobs.scm	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

MikeSol

On 2011/07/23 20:54:40, MikeSol wrote: > Should fix issue 1604. Passes regtests.

12 years, 9 months ago (2011-07-27 09:33:21 UTC) #2

Neil Puttock

LGTM. http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly File input/regression/multi-measure-rest-staff-position.ly (right): http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly#newcode1 input/regression/multi-measure-rest-staff-position.ly:1: \version "2.15.7" 2.15.9 http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly#newcode9 input/regression/multi-measure-rest-staff-position.ly:9: \relative c'{ c' ...

12 years, 8 months ago (2011-08-10 15:47:04 UTC) #5

Reinhold

LGTM. I wonder why we use get_positino in the first place, which uses the "staff-position" ...

12 years, 8 months ago (2011-08-10 16:04:22 UTC) #6

MikeSol

12 years, 8 months ago (2011-08-11 22:40:47 UTC) #7

Pushed as e75f38b1a9adaf7752ced683fff0e6ec01bd8a13.

Cheers,
MS

Expand All Messages | Collapse All Messages