Issue 4818041: code review 4818041: CONTRIBUTORS: add Mike Solomon (Google CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4818041: code review 4818041: CONTRIBUTORS: add Mike Solomon (Google CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bradfitz

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

CONTRIBUTORS: add Mike Solomon (Google CLA)

Patch Set 1 #

Patch Set 2 : diff -r f2765b9aec9b https://go.googlecode.com/hg #

Patch Set 3 : diff -r f2765b9aec9b https://go.googlecode.com/hg #

Patch Set 4 : diff -r f2765b9aec9b https://go.googlecode.com/hg #

Patch Set 5 : diff -r f2765b9aec9b https://go.googlecode.com/hg #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	CONTRIBUTORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

12 years, 9 months ago (2011-07-20 20:26:38 UTC) #1

bradfitz

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 9 months ago (2011-07-20 20:30:39 UTC) #3

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=b8e4b6428894 *** CONTRIBUTORS: add Mike Solomon (Google CLA) R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4818041

12 years, 9 months ago (2011-07-20 20:30:51 UTC) #4

bradfitz

12 years, 9 months ago (2011-07-20 20:30:56 UTC) #5

fail

On Wed, Jul 20, 2011 at 1:30 PM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
>
http://codereview.appspot.com/**4818041/<http://codereview.appspot.com/4818041/>
>

Expand All Messages | Collapse All Messages