code review 4815074: net: join and leave a IPv6 group address, on a specific...

net: join and leave a IPv6 group address, on a specific interface

This CL changes both JoinGroup and LeaveGroup methods
to take an interface as an argument for enabling IPv6
group address join/leave, join a group address on a
specific interface.

[mikio, 2011-07-31 17:57:14]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-07-31 17:59:00]

And this CL requires CL 4808062.

On 2011/07/31 17:57:14, mikioh wrote:
> Hello mailto:rsc@golang.org, mailto:dave@cheney.net (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

[mikio, 2011-08-01 04:34:58]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2011-08-03 11:08:27]

Hi Mikioh,

This doesn't appear to work with +tip, should I apply any other patches before
this one ?


lucky(~/go/src) % hg identify
2ffd085d488a+ tip
lucky(~/go/src) % make -C pkg/net test
make: Entering directory `/home/dfc/go/src/pkg/net'
gotest
rm -f _test/net.a
6g  -o _gotest_.6 dial.go dnsclient.go dnsmsg.go fd_linux.go hosts.go
interface.go ip.go ipsock.go iprawsock.go net.go parse.go pipe.go sock.go
tcpsock.go udpsock.go unixsock.go  dnsclient_unix.go dnsconfig.go fd.go file.go
interface_linux.go lookup_unix.go newpollserver.go port.go sendfile_linux.go
sock_linux.go  _obj/cgo_linux.cgo1.go _obj/cgo_unix.cgo1.go _obj/_cgo_gotypes.go
dialgoogle_test.go dnsmsg_test.go dnsname_test.go file_test.go hosts_test.go
interface_test.go ip_test.go ipraw_test.go multicast_test.go net_test.go
parse_test.go pipe_test.go port_test.go server_test.go srv_test.go
timeout_test.go
multicast_test.go:74: ifi.MulticastAddrs undefined (type *Interface has no field
or method MulticastAddrs)
multicast_test.go:78: typechecking loop
make: *** [_gotest_.6] Error 1
gotest: "/home/dfc/go/bin/gomake testpackage GOTESTFILES=dialgoogle_test.go
dnsmsg_test.go dnsname_test.go file_test.go hosts_test.go interface_test.go
ip_test.go ipraw_test.go multicast_test.go net_test.go parse_test.go
pipe_test.go port_test.go server_test.go srv_test.go timeout_test.go" failed:
exit status 2
make: *** [test] Error 2
make: Leaving directory `/home/dfc/go/src/pkg/net'

[mikio, 2011-08-03 11:43:20]

Hi,

On Wed, Aug 3, 2011 at 8:08 PM,  <dave@cheney.net> wrote:

> This doesn't appear to work with +tip, should I apply any other patches
> before this one ?

Yep, please try after patching both CL 4808062 and CL  4826056 on BSD variants.
On Linux you need only CL 4808062.

-- Mikio Hara

[mikio, 2011-08-08 03:29:59]

Hello rsc@golang.org, dave@cheney.net, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-08-09 00:46:58]

Hello rsc@golang.org, dave@cheney.net, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-08-16 20:09:21]

LGTM

Is there any merit in using an IP address
instead of an *Interface, as in the other CL?

[mikio, 2011-08-17 02:56:16]

On Wed, Aug 17, 2011 at 5:09 AM,  <rsc@golang.org> wrote:

> Is there any merit in using an IP address
> instead of an *Interface, as in the other CL?

For now I don't see any good reason to use IP address for specifying
incoming/outgoing IP interface.

If we have a nice IP address parser that parsing IP address w/ scope
zone notation like "fe80::1%en1", "2011::1%company_divA-dept1"
and platforms, kernels support more IPv6 scope zones such as
admin-local, organization-local, using an IP address might be a bit
more generic than *Interface.

I had been waiting for general IPv6 deployment the last decade but
that not come. Perhaps in next two, three decades, it would be IPv4/
v6 dual-stack era with the use of up to IPv6 link-local scope zone.

So I'd prefer to using *Interface right now.

-- Mikio

[rsc, 2011-08-17 17:29:45]

LGTM

please hg sync + hg mail

[mikio, 2011-08-17 21:51:55]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-08-18 06:40:48]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-08-18 16:22:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=ca489fa6a75e ***

net: join and leave a IPv6 group address, on a specific interface

This CL changes both JoinGroup and LeaveGroup methods
to take an interface as an argument for enabling IPv6
group address join/leave, join a group address on a
specific interface.

R=rsc, dave
CC=golang-dev
http://codereview.appspot.com/4815074

Committer: Russ Cox <rsc@golang.org>