Sketch for fix of issue 307

Sketch for fix of issue 307

[MikeSol, 2011-07-24 14:43:16]

Please don't run regtests yet on this patch - it is up to see if people are OK
with this approach.  It is a brute-force approach that will slow down lilypond
for slurs that have extra-object-collisions, but I think it'll cover the grand
majority of cases.

[MikeSol, 2011-07-25 13:57:26]

On 2011/07/24 14:43:16, MikeSol wrote:
> Please don't run regtests yet on this patch - it is up to see if people are OK
> with this approach.  It is a brute-force approach that will slow down lilypond
> for slurs that have extra-object-collisions, but I think it'll cover the grand
> majority of cases.

Ran regtests on my nex VirtualBox LilyBuntu (which is faster than my native mac
OS!).  There is one regression that comes up in grace-sync.ly, but this is
because of issue 1782.

Cheers,
MS

[hanwenn, 2011-07-26 03:01:06]

regtest missing.

http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):

http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286
lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 = m4g1c
padding over extra encompass. make tweakable?
"magic"

Do you need the 0.5 at all? The quanting and the shape of the slur already offer
quite some flexibility.

[mike_apollinemike.com, 2011-07-26 06:14:47]

On Jul 26, 2011, at 5:01 AM, hanwenn@gmail.com wrote:

> regtest missing.
> 
> 
> http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc
> File lily/slur-scoring.cc (right):
> 
>
http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286
> lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 =
> m4g1c padding over extra encompass. make tweakable?
> "magic"
> 
> Do you need the 0.5 at all? The quanting and the shape of the slur
> already offer quite some flexibility.
> 

The test case from the tracker doesn't work without the 0.5, which is truly a
magic number that represents "that which was necessary to make the test case
work and not look ugly."
I'll add a regtest later today.

Cheers,
MS

[MikeSol, 2011-07-26 16:05:41]

On 2011/07/26 06:14:47, mike_apollinemike.com wrote:
> On Jul 26, 2011, at 5:01 AM, mailto:hanwenn@gmail.com wrote:
> 
> > regtest missing.
> > 
> > 
> > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc
> > File lily/slur-scoring.cc (right):
> > 
> >
>
http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286
> > lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 =
> > m4g1c padding over extra encompass. make tweakable?
> > "magic"
> > 
> > Do you need the 0.5 at all? The quanting and the shape of the slur
> > already offer quite some flexibility.
> > 
> 
> The test case from the tracker doesn't work without the 0.5, which is truly a
> magic number that represents "that which was necessary to make the test case
> work and not look ugly."
> I'll add a regtest later today.
> 
> Cheers,
> MS

I did some math to be able to scrub the padding & added a regtest.

Cheers,
MS

[Bertrand Bordage, 2011-08-09 19:39:40]

This needs an update to be applied.

Cheers,
Bertrand

[pkx166h, 2011-09-24 20:09:41]

passes make and reg tests

[pkx166h, 2011-09-29 21:30:20]

Passes make but fails make check

--snip--

job 4 terminated with signal: 6


job 3 terminated with signal: 6
fatal error: Children (4 3) exited with errors.
command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
/home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
/home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation -I
/home/jlowe/lilypond-git/Documentation/snippets -I
/home/jlowe/lilypond-git/input/regression/ -I
/home/jlowe/lilypond-git/Documentation/included/ -I
/home/jlowe/lilypond-git/build/mf/out/ -I /home/jlowe/lilypond-git/build/mf/out/
-I /home/jlowe/lilypond-git/Documentation/pictures -I
/home/jlowe/lilypond-git/build/Documentation/pictures/./out-test -dbackend=eps
--formats=ps -djob-count=7 -dseparate-log-files -dinclude-eps-fonts
-dgs-load-lily-fonts --header=texidoc -I
/home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
-dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I 
"/home/jlowe/lilypond-git/build/out/lybook-testdb"  -I 
"/home/jlowe/lilypond-git/build/input/regression"  -I 
"/home/jlowe/lilypond-git/input/regression"  -I 
"/home/jlowe/lilypond-git/build/input/regression/out-test"  -I 
"/home/jlowe/lilypond-git/input"  -I  "/home/jlowe/lilypond-git/Documentation" 
-I  "/home/jlowe/lilypond-git/Documentation/snippets"  -I 
"/home/jlowe/lilypond-git/input/regression"  -I 
"/home/jlowe/lilypond-git/Documentation/included"  -I 
"/home/jlowe/lilypond-git/build/mf/out"  -I 
"/home/jlowe/lilypond-git/build/mf/out"  -I 
"/home/jlowe/lilypond-git/Documentation/pictures"  -I 
"/home/jlowe/lilypond-git/build/Documentation/pictures/out-test" --formats=eps 
-deps-box-padding=3.000000  -dread-file-list -dno-strip-output-dir 
"/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--760084111.ly"
Child returned 1
make[2]: *** [out-test/collated-files.texi] Error 1
rm out-test/weblinks.itexi
make[2]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression'
make[1]: *** [local-test] Error 2
make[1]: Leaving directory `/home/jlowe/lilypond-git/build/input/regression'
make: *** [test] Error 2
jlowe@jlowe-lilybuntu2:~/lilypond-git/build$ 

--snip--

James

[reinhold_kainhofer.com, 2011-09-29 23:01:20]

Am Thursday, 29. September 2011, 23:30:20 schrieb pkx166h@gmail.com:
> Passes make but fails make check
> 
> --snip--
> 
> job 4 terminated with signal: 6
> 
> 
> job 3 terminated with signal: 6
> fatal error: Children (4 3) exited with errors.
> command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
> /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
> /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation
> -I /home/jlowe/lilypond-git/Documentation/snippets -I
> /home/jlowe/lilypond-git/input/regression/ -I
> /home/jlowe/lilypond-git/Documentation/included/ -I
> /home/jlowe/lilypond-git/build/mf/out/ -I
> /home/jlowe/lilypond-git/build/mf/out/ -I
> /home/jlowe/lilypond-git/Documentation/pictures -I
> /home/jlowe/lilypond-git/build/Documentation/pictures/./out-test
> -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files
> -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I
> /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
> -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I
> "/home/jlowe/lilypond-git/build/out/lybook-testdb"  -I
> "/home/jlowe/lilypond-git/build/input/regression"  -I
> "/home/jlowe/lilypond-git/input/regression"  -I
> "/home/jlowe/lilypond-git/build/input/regression/out-test"  -I
> "/home/jlowe/lilypond-git/input"  -I
> "/home/jlowe/lilypond-git/Documentation"  -I
> "/home/jlowe/lilypond-git/Documentation/snippets"  -I
> "/home/jlowe/lilypond-git/input/regression"  -I
> "/home/jlowe/lilypond-git/Documentation/included"  -I
> "/home/jlowe/lilypond-git/build/mf/out"  -I
> "/home/jlowe/lilypond-git/build/mf/out"  -I
> "/home/jlowe/lilypond-git/Documentation/pictures"  -I
> "/home/jlowe/lilypond-git/build/Documentation/pictures/out-test"
> --formats=eps  -deps-box-padding=3.000000  -dread-file-list
> -dno-strip-output-dir
> "/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--760084111.
> ly" Child returned 1
> make[2]: *** [out-test/collated-files.texi] Error 1
> rm out-test/weblinks.itexi
> make[2]: Leaving directory
> `/home/jlowe/lilypond-git/build/input/regression'
> make[1]: *** [local-test] Error 2
> make[1]: Leaving directory
> `/home/jlowe/lilypond-git/build/input/regression'
> make: *** [test] Error 2
> jlowe@jlowe-lilybuntu2:~/lilypond-git/build$

Hmm, it would be REALLY useful if the regtest run could print out the error. 
That's the relevant information, not how the regtests were built (i.e. the 30 
lines of lilypond-book invocation that tells us nothing).

Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org

[mike_apollinemike.com, 2011-09-29 23:05:48]

My bad - I made the change right before leaving for rehearsal w/o running
regtests.  I should have waited to make the patch public until I had verified
the change.  I'll be swamped tomorrow, but I'll get on it this weekend...

Cheers,
MS

On Sep 30, 2011, at 1:01 AM, Reinhold Kainhofer wrote:

> Am Thursday, 29. September 2011, 23:30:20 schrieb pkx166h@gmail.com:
>> Passes make but fails make check
>> 
>> --snip--
>> 
>> job 4 terminated with signal: 6
>> 
>> 
>> job 3 terminated with signal: 6
>> fatal error: Children (4 3) exited with errors.
>> command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
>> /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
>> /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation
>> -I /home/jlowe/lilypond-git/Documentation/snippets -I
>> /home/jlowe/lilypond-git/input/regression/ -I
>> /home/jlowe/lilypond-git/Documentation/included/ -I
>> /home/jlowe/lilypond-git/build/mf/out/ -I
>> /home/jlowe/lilypond-git/build/mf/out/ -I
>> /home/jlowe/lilypond-git/Documentation/pictures -I
>> /home/jlowe/lilypond-git/build/Documentation/pictures/./out-test
>> -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files
>> -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I
>> /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
>> -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I
>> "/home/jlowe/lilypond-git/build/out/lybook-testdb"  -I
>> "/home/jlowe/lilypond-git/build/input/regression"  -I
>> "/home/jlowe/lilypond-git/input/regression"  -I
>> "/home/jlowe/lilypond-git/build/input/regression/out-test"  -I
>> "/home/jlowe/lilypond-git/input"  -I
>> "/home/jlowe/lilypond-git/Documentation"  -I
>> "/home/jlowe/lilypond-git/Documentation/snippets"  -I
>> "/home/jlowe/lilypond-git/input/regression"  -I
>> "/home/jlowe/lilypond-git/Documentation/included"  -I
>> "/home/jlowe/lilypond-git/build/mf/out"  -I
>> "/home/jlowe/lilypond-git/build/mf/out"  -I
>> "/home/jlowe/lilypond-git/Documentation/pictures"  -I
>> "/home/jlowe/lilypond-git/build/Documentation/pictures/out-test"
>> --formats=eps  -deps-box-padding=3.000000  -dread-file-list
>> -dno-strip-output-dir
>> "/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--760084111.
>> ly" Child returned 1
>> make[2]: *** [out-test/collated-files.texi] Error 1
>> rm out-test/weblinks.itexi
>> make[2]: Leaving directory
>> `/home/jlowe/lilypond-git/build/input/regression'
>> make[1]: *** [local-test] Error 2
>> make[1]: Leaving directory
>> `/home/jlowe/lilypond-git/build/input/regression'
>> make: *** [test] Error 2
>> jlowe@jlowe-lilybuntu2:~/lilypond-git/build$
> 
> Hmm, it would be REALLY useful if the regtest run could print out the error. 
> That's the relevant information, not how the regtests were built (i.e. the 30 
> lines of lilypond-book invocation that tells us nothing).
> 
> Cheers,
> Reinhold
> 
> -- 
> ------------------------------------------------------------------
> Reinhold Kainhofer, reinhold@kainhofer.com, http://reinhold.kainhofer.com/
> * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
> * http://www.fam.tuwien.ac.at/, DVR: 0005886
> * LilyPond, Music typesetting, http://www.lilypond.org

[pkx166h, 2011-09-30 12:51:38]

Hello,

On Fri, Sep 30, 2011 at 12:01 AM, Reinhold Kainhofer
<reinhold@kainhofer.com> wrote:
> Am Thursday, 29. September 2011, 23:30:20 schrieb pkx166h@gmail.com:
>> Passes make but fails make check
>>
>> --snip--
>>
>> job 4 terminated with signal: 6
>>
>>
>> job 3 terminated with signal: 6
>> fatal error: Children (4 3) exited with errors.
>> command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
>> /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
>> /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation
>> -I /home/jlowe/lilypond-git/Documentation/snippets -I
>> /home/jlowe/lilypond-git/input/regression/ -I
>> /home/jlowe/lilypond-git/Documentation/included/ -I
>> /home/jlowe/lilypond-git/build/mf/out/ -I
>> /home/jlowe/lilypond-git/build/mf/out/ -I
>> /home/jlowe/lilypond-git/Documentation/pictures -I
>> /home/jlowe/lilypond-git/build/Documentation/pictures/./out-test
>> -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files
>> -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I
>> /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
>> -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I
>> "/home/jlowe/lilypond-git/build/out/lybook-testdb"  -I
>> "/home/jlowe/lilypond-git/build/input/regression"  -I
>> "/home/jlowe/lilypond-git/input/regression"  -I
>> "/home/jlowe/lilypond-git/build/input/regression/out-test"  -I
>> "/home/jlowe/lilypond-git/input"  -I
>> "/home/jlowe/lilypond-git/Documentation"  -I
>> "/home/jlowe/lilypond-git/Documentation/snippets"  -I
>> "/home/jlowe/lilypond-git/input/regression"  -I
>> "/home/jlowe/lilypond-git/Documentation/included"  -I
>> "/home/jlowe/lilypond-git/build/mf/out"  -I
>> "/home/jlowe/lilypond-git/build/mf/out"  -I
>> "/home/jlowe/lilypond-git/Documentation/pictures"  -I
>> "/home/jlowe/lilypond-git/build/Documentation/pictures/out-test"
>> --formats=eps  -deps-box-padding=3.000000  -dread-file-list
>> -dno-strip-output-dir
>> "/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--760084111.
>> ly" Child returned 1
>> make[2]: *** [out-test/collated-files.texi] Error 1
>> rm out-test/weblinks.itexi
>> make[2]: Leaving directory
>> `/home/jlowe/lilypond-git/build/input/regression'
>> make[1]: *** [local-test] Error 2
>> make[1]: Leaving directory
>> `/home/jlowe/lilypond-git/build/input/regression'
>> make: *** [test] Error 2
>> jlowe@jlowe-lilybuntu2:~/lilypond-git/build$
>
> Hmm, it would be REALLY useful if the regtest run could print out the error.
> That's the relevant information, not how the regtests were built (i.e. the 30
> lines of lilypond-book invocation that tells us nothing).
>

Well the make check often does give me the ly file that has the
problem but in this case for a reason I have never understood, during
make check I get the 'texidoc strings' (if that is the right phrase)
for the fingerings of the woodwind diagrams, and it is at this point I
suddenly got job terminated.

Usually I get a file that it was working on when this happened but not
in this case.

There are points in the make check process where it is impossible to
see where teh process is at - and I guess this makes it harder if you
are running -j7 makes.

-- 
--
James

[MikeSol, 2011-10-03 04:28:16]

On 2011/09/30 12:51:38, J_lowe wrote:
> Hello,
> 
> On Fri, Sep 30, 2011 at 12:01 AM, Reinhold Kainhofer
> <mailto:reinhold@kainhofer.com> wrote:
> > Am Thursday, 29. September 2011, 23:30:20 schrieb pkx166h@gmail.com:
> >> Passes make but fails make check
> >>
> >> --snip--
> >>
> >> job 4 terminated with signal: 6
> >>
> >>
> >> job 3 terminated with signal: 6
> >> fatal error: Children (4 3) exited with errors.
> >> command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
> >> /home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
> >> /home/jlowe/lilypond-git/input -I /home/jlowe/lilypond-git/Documentation
> >> -I /home/jlowe/lilypond-git/Documentation/snippets -I
> >> /home/jlowe/lilypond-git/input/regression/ -I
> >> /home/jlowe/lilypond-git/Documentation/included/ -I
> >> /home/jlowe/lilypond-git/build/mf/out/ -I
> >> /home/jlowe/lilypond-git/build/mf/out/ -I
> >> /home/jlowe/lilypond-git/Documentation/pictures -I
> >> /home/jlowe/lilypond-git/build/Documentation/pictures/./out-test
> >> -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files
> >> -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I
> >> /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
> >> -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I
> >> "/home/jlowe/lilypond-git/build/out/lybook-testdb" &nbsp;-I
> >> "/home/jlowe/lilypond-git/build/input/regression" &nbsp;-I
> >> "/home/jlowe/lilypond-git/input/regression" &nbsp;-I
> >> "/home/jlowe/lilypond-git/build/input/regression/out-test" &nbsp;-I
> >> "/home/jlowe/lilypond-git/input" &nbsp;-I
> >> "/home/jlowe/lilypond-git/Documentation" &nbsp;-I
> >> "/home/jlowe/lilypond-git/Documentation/snippets" &nbsp;-I
> >> "/home/jlowe/lilypond-git/input/regression" &nbsp;-I
> >> "/home/jlowe/lilypond-git/Documentation/included" &nbsp;-I
> >> "/home/jlowe/lilypond-git/build/mf/out" &nbsp;-I
> >> "/home/jlowe/lilypond-git/build/mf/out" &nbsp;-I
> >> "/home/jlowe/lilypond-git/Documentation/pictures" &nbsp;-I
> >> "/home/jlowe/lilypond-git/build/Documentation/pictures/out-test"
> >> --formats=eps &nbsp;-deps-box-padding=3.000000 &nbsp;-dread-file-list
> >> -dno-strip-output-dir
> >> "/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names--760084111.
> >> ly" Child returned 1
> >> make[2]: *** [out-test/collated-files.texi] Error 1
> >> rm out-test/weblinks.itexi
> >> make[2]: Leaving directory
> >> `/home/jlowe/lilypond-git/build/input/regression'
> >> make[1]: *** [local-test] Error 2
> >> make[1]: Leaving directory
> >> `/home/jlowe/lilypond-git/build/input/regression'
> >> make: *** [test] Error 2
> >> jlowe@jlowe-lilybuntu2:~/lilypond-git/build$
> >
> > Hmm, it would be REALLY useful if the regtest run could print out the error.
> > That's the relevant information, not how the regtests were built (i.e. the
30
> > lines of lilypond-book invocation that tells us nothing).
> >
> 
> Well the make check often does give me the ly file that has the
> problem but in this case for a reason I have never understood, during
> make check I get the 'texidoc strings' (if that is the right phrase)
> for the fingerings of the woodwind diagrams, and it is at this point I
> suddenly got job terminated.
> 
> Usually I get a file that it was working on when this happened but not
> in this case.
> 
> There are points in the make check process where it is impossible to
> see where teh process is at - and I guess this makes it harder if you
> are running -j7 makes.
> 
> -- 
> --
> James

James - could you please run the regtests again?  I am not getting this crash.

All the best,
Mike

[Keith, 2011-10-03 06:24:18]

Mike, 
Maybe your flower/out didn't get rebuilt after config --disable-optimising.  I
had to rm flower/out/*

http://codereview.appspot.com/4813048/diff/29001/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):

http://codereview.appspot.com/4813048/diff/29001/lily/slur-scoring.cc#newcode274
lily/slur-scoring.cc:274: Real y_place = linear_interpolate
(extra_encompass_infos_[i].extents_[X_AXIS].center (),
input/regression/tablature-tie-spanner.ly
has the "Assertion `!is_empty ()' failed" in center()

[pkx166h, 2011-10-03 07:28:34]

Passes make and make check

[mike_apollinemike.com, 2011-10-04 06:17:50]

On Oct 3, 2011, at 8:24 AM, k-ohara5a5a@oco.net wrote:

> Mike,
> Maybe your flower/out didn't get rebuilt after config
> --disable-optimising.  I had to rm flower/out/*
> 
> 
> http://codereview.appspot.com/4813048/diff/29001/lily/slur-scoring.cc
> File lily/slur-scoring.cc (right):
> 
>
http://codereview.appspot.com/4813048/diff/29001/lily/slur-scoring.cc#newcode274
> lily/slur-scoring.cc:274: Real y_place = linear_interpolate
> (extra_encompass_infos_[i].extents_[X_AXIS].center (),
> input/regression/tablature-tie-spanner.ly
> has the "Assertion `!is_empty ()' failed" in center()
> 

Fixed in the most recent patchset.

Cheers,
MS

[pkx166h, 2011-10-04 06:32:00]

passes make and make check