Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(132)

Issue 4813048: Sketch for fix of issue 307 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by MikeSol
Modified:
12 years, 5 months ago
Reviewers:
mike, Keith, Bertrand Bordage, reinhold, pkx166h, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Sketch for fix of issue 307

Patch Set 1 #

Patch Set 2 : Uses linear interpolation. #

Total comments: 1

Patch Set 3 : Adds a regtest, eliminates padding. #

Patch Set 4 : Rebased against current master. #

Patch Set 5 : issue 307 against current master #

Patch Set 6 : issue 307 against current master #

Patch Set 7 : issue 307 rebased #

Patch Set 8 : issue 307 - adds encompass-object-range-overshoot #

Patch Set 9 : Rebase against current master for issue 307. #

Total comments: 1

Patch Set 10 : Fixes assertion error (issue 307). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -3 lines) Patch
A input/regression/slur-shift-region.ly View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M lily/include/misc.hh View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M lily/include/slur-score-parameters.hh View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M lily/slur-score-parameters.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M lily/slur-scoring.cc View 1 2 3 4 5 6 7 8 9 3 chunks +44 lines, -2 lines 0 comments Download
M scm/layout-slur.scm View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16
MikeSol
Please don't run regtests yet on this patch - it is up to see if ...
12 years, 8 months ago (2011-07-24 14:43:16 UTC) #1
MikeSol
On 2011/07/24 14:43:16, MikeSol wrote: > Please don't run regtests yet on this patch - ...
12 years, 8 months ago (2011-07-25 13:57:26 UTC) #2
hanwenn
regtest missing. http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc File lily/slur-scoring.cc (right): http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286 lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 ...
12 years, 8 months ago (2011-07-26 03:01:06 UTC) #3
mike_apollinemike.com
On Jul 26, 2011, at 5:01 AM, hanwenn@gmail.com wrote: > regtest missing. > > > ...
12 years, 8 months ago (2011-07-26 06:14:47 UTC) #4
MikeSol
On 2011/07/26 06:14:47, mike_apollinemike.com wrote: > On Jul 26, 2011, at 5:01 AM, mailto:hanwenn@gmail.com wrote: ...
12 years, 8 months ago (2011-07-26 16:05:41 UTC) #5
Bertrand Bordage
This needs an update to be applied. Cheers, Bertrand
12 years, 7 months ago (2011-08-09 19:39:40 UTC) #6
pkx166h
passes make and reg tests
12 years, 6 months ago (2011-09-24 20:09:41 UTC) #7
pkx166h
Passes make but fails make check --snip-- job 4 terminated with signal: 6 job 3 ...
12 years, 6 months ago (2011-09-29 21:30:20 UTC) #8
reinhold_kainhofer.com
Am Thursday, 29. September 2011, 23:30:20 schrieb pkx166h@gmail.com: > Passes make but fails make check ...
12 years, 6 months ago (2011-09-29 23:01:20 UTC) #9
mike_apollinemike.com
My bad - I made the change right before leaving for rehearsal w/o running regtests. ...
12 years, 6 months ago (2011-09-29 23:05:48 UTC) #10
pkx166h
Hello, On Fri, Sep 30, 2011 at 12:01 AM, Reinhold Kainhofer <reinhold@kainhofer.com> wrote: > Am ...
12 years, 6 months ago (2011-09-30 12:51:38 UTC) #11
MikeSol
On 2011/09/30 12:51:38, J_lowe wrote: > Hello, > > On Fri, Sep 30, 2011 at ...
12 years, 6 months ago (2011-10-03 04:28:16 UTC) #12
Keith
Mike, Maybe your flower/out didn't get rebuilt after config --disable-optimising. I had to rm flower/out/* ...
12 years, 6 months ago (2011-10-03 06:24:18 UTC) #13
pkx166h
Passes make and make check
12 years, 6 months ago (2011-10-03 07:28:34 UTC) #14
mike_apollinemike.com
On Oct 3, 2011, at 8:24 AM, k-ohara5a5a@oco.net wrote: > Mike, > Maybe your flower/out ...
12 years, 6 months ago (2011-10-04 06:17:50 UTC) #15
pkx166h
12 years, 6 months ago (2011-10-04 06:32:00 UTC) #16
passes make and make check
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b