code review 4811048: sort: remove testing cycle

sort: remove testing cycle

import cycle:
        "testing"
        imports "flag"
        imports "sort"
        imports "testing"

[rsc, 2011-07-23 00:39:11]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-23 00:44:34]

LGTM
but why didn't this come up before?

[rsc, 2011-07-23 01:00:53]

On Fri, Jul 22, 2011 at 20:44,  <r@golang.org> wrote:
> LGTM
> but why didn't this come up before?

the linker never checked.

the runtime checks while running init functions,
but that only catches cycles involving packages
with init functions.  there is an optimization that
if a package has no init to do, it notes that in its
object so importers don't bother running the init.
that eliminates the place where the runtime
has the check.

[rsc, 2011-07-23 01:17:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=b2bdccd98b04 ***

sort: remove testing cycle

import cycle:
        "testing"
        imports "flag"
        imports "sort"
        imports "testing"

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4811048