Remove unused line_maps field last_listed

[Gabriel Charette, 2011-07-28 17:55:15]

The last_listed field in struct line_maps was never used, removed it.

Gab

2011-07-28  Gabriel Charette  <gchare@google.com>

	* libcpp/include/line-map.h (struct line_maps):
          Remove unused field last_listed.

diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h
index 3234423..f1d5bee 100644
--- a/libcpp/include/line-map.h
+++ b/libcpp/include/line-map.h
@@ -76,11 +76,6 @@ struct GTY(()) line_maps {
 
   unsigned int cache;
 
-  /* The most recently listed include stack, if any, starts with
-     LAST_LISTED as the topmost including file.  -1 indicates nothing
-     has been listed yet.  */
-  int last_listed;
-
   /* Depth of the include stack, including the current file.  */
   unsigned int depth;
 
diff --git a/libcpp/line-map.c b/libcpp/line-map.c
index 86e2484..dd3f11c 100644
--- a/libcpp/line-map.c
+++ b/libcpp/line-map.c
@@ -34,7 +34,6 @@ linemap_init (struct line_maps *set)
   set->maps = NULL;
   set->allocated = 0;
   set->used = 0;
-  set->last_listed = -1;
   set->trace_includes = false;
   set->depth = 0;
   set->cache = 0;

--
This patch is available for review at http://codereview.appspot.com/4810058

[Gabriel Charette, 2011-07-28 17:58:15]

Forgot to mention:

Tested with bootstrap build and full regression testing.

On 2011/07/28 17:55:15, Gabriel Charette wrote:
> The last_listed field in struct line_maps was never used, removed it.
> 
> Gab
> 
> 2011-07-28  Gabriel Charette  <mailto:gchare@google.com>
> 
> 	* libcpp/include/line-map.h (struct line_maps):
>           Remove unused field last_listed.
> 
> diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h
> index 3234423..f1d5bee 100644
> --- a/libcpp/include/line-map.h
> +++ b/libcpp/include/line-map.h
> @@ -76,11 +76,6 @@ struct GTY(()) line_maps {
>  
>    unsigned int cache;
>  
> -  /* The most recently listed include stack, if any, starts with
> -     LAST_LISTED as the topmost including file.  -1 indicates nothing
> -     has been listed yet.  */
> -  int last_listed;
> -
>    /* Depth of the include stack, including the current file.  */
>    unsigned int depth;
>  
> diff --git a/libcpp/line-map.c b/libcpp/line-map.c
> index 86e2484..dd3f11c 100644
> --- a/libcpp/line-map.c
> +++ b/libcpp/line-map.c
> @@ -34,7 +34,6 @@ linemap_init (struct line_maps *set)
>    set->maps = NULL;
>    set->allocated = 0;
>    set->used = 0;
> -  set->last_listed = -1;
>    set->trace_includes = false;
>    set->depth = 0;
>    set->cache = 0;
> 
> --
> This patch is available for review at http://codereview.appspot.com/4810058

[dodji_seketeli.org, 2011-07-28 19:36:57]

Hello Gabriel,

gchare@google.com (Gabriel Charette) a écrit:

> 2011-07-28  Gabriel Charette  <gchare@google.com>
>
> 	* libcpp/include/line-map.h (struct line_maps):
>           Remove unused field last_listed.
>

I cannot approve or reject this patch, but FWIW, it looks good (and
obvious) to me.  I am CC-ing Tom.

Thanks.

> diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h
> index 3234423..f1d5bee 100644
> --- a/libcpp/include/line-map.h
> +++ b/libcpp/include/line-map.h
> @@ -76,11 +76,6 @@ struct GTY(()) line_maps {
>  
>    unsigned int cache;
>  
> -  /* The most recently listed include stack, if any, starts with
> -     LAST_LISTED as the topmost including file.  -1 indicates nothing
> -     has been listed yet.  */
> -  int last_listed;
> -
>    /* Depth of the include stack, including the current file.  */
>    unsigned int depth;
>  
> diff --git a/libcpp/line-map.c b/libcpp/line-map.c
> index 86e2484..dd3f11c 100644
> --- a/libcpp/line-map.c
> +++ b/libcpp/line-map.c
> @@ -34,7 +34,6 @@ linemap_init (struct line_maps *set)
>    set->maps = NULL;
>    set->allocated = 0;
>    set->used = 0;
> -  set->last_listed = -1;
>    set->trace_includes = false;
>    set->depth = 0;
>    set->cache = 0;
>
> --
> This patch is available for review at http://codereview.appspot.com/4810058

-- 
		Dodji

[tromey_redhat.com, 2011-07-28 19:41:50]

>>>>> "Gabriel" == Gabriel Charette <gchare@google.com> writes:

Gabriel> 2011-07-28  Gabriel Charette  <gchare@google.com>
Gabriel> 	* libcpp/include/line-map.h (struct line_maps):
Gabriel>           Remove unused field last_listed.

Ok.

Tom