Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4810043: code review 4810043: html: sync html/testdata/webkit with upstream WebKit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by nigeltao
Modified:
12 years, 9 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

html: sync html/testdata/webkit with upstream WebKit. As $GOROOT/src/pkg/html/testdata/webkit/README says, we're pulling from $WEBKITROOT/LayoutTests/html5lib/resources.

Patch Set 1 #

Patch Set 2 : diff -r 0713c6cee448 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0713c6cee448 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0713c6cee448 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6139 lines, -233 lines) Patch
A src/pkg/html/testdata/webkit/adoption01.dat View 1 1 chunk +194 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/adoption02.dat View 1 1 chunk +31 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/comments01.dat View 1 3 chunks +13 lines, -4 lines 0 comments Download
M src/pkg/html/testdata/webkit/doctype01.dat View 1 13 chunks +49 lines, -14 lines 0 comments Download
R src/pkg/html/testdata/webkit/dom2string.js View 1 1 chunk +0 lines, -135 lines 0 comments Download
M src/pkg/html/testdata/webkit/entities01.dat View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/pkg/html/testdata/webkit/entities02.dat View 1 1 chunk +120 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/html5test-com.dat View 1 1 chunk +246 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/inbody01.dat View 1 1 chunk +43 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/isindex.dat View 1 1 chunk +40 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/pending-spec-changes.dat View 1 1 chunk +28 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/pending-spec-changes-plain-text-unsafe.dat View 1 Binary file 0 comments Download
A src/pkg/html/testdata/webkit/plain-text-unsafe.dat View 1 1 chunk +8 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/scripted/adoption01.dat View 1 1 chunk +15 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/scripted/webkit01.dat View 1 1 chunk +28 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tables01.dat View 1 1 chunk +197 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests1.dat View 1 5 chunks +31 lines, -28 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests10.dat View 1 2 chunks +369 lines, -0 lines 0 comments Download
R src/pkg/html/testdata/webkit/tests13.dat View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests14.dat View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/html/testdata/webkit/tests15.dat View 1 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/html/testdata/webkit/tests17.dat View 1 1 chunk +153 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests18.dat View 1 1 chunk +269 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests19.dat View 1 1 chunk +1220 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests2.dat View 1 3 chunks +26 lines, -1 line 0 comments Download
A src/pkg/html/testdata/webkit/tests20.dat View 1 1 chunk +455 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests21.dat View 1 1 chunk +221 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests22.dat View 1 1 chunk +157 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests23.dat View 1 1 chunk +155 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests24.dat View 1 1 chunk +79 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests25.dat View 1 1 chunk +219 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests26.dat View 1 1 chunk +195 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests3.dat View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests6.dat View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/tests9.dat View 1 1 chunk +27 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tests_innerHTML_1.dat View 1 1 chunk +733 lines, -0 lines 0 comments Download
A src/pkg/html/testdata/webkit/tricky01.dat View 1 1 chunk +261 lines, -0 lines 0 comments Download
M src/pkg/html/testdata/webkit/webkit01.dat View 1 3 chunks +429 lines, -31 lines 0 comments Download
A src/pkg/html/testdata/webkit/webkit02.dat View 1 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2011-07-21 02:40:42 UTC) #1
r
LGTM
12 years, 9 months ago (2011-07-21 02:42:30 UTC) #2
nigeltao
12 years, 9 months ago (2011-07-21 02:50:55 UTC) #3 
*** Submitted as http://code.google.com/p/go/source/detail?r=e325563c6a33 ***

html: sync html/testdata/webkit with upstream WebKit.

As $GOROOT/src/pkg/html/testdata/webkit/README says, we're pulling from
$WEBKITROOT/LayoutTests/html5lib/resources.

R=r
CC=golang-dev
http://codereview.appspot.com/4810043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b