code review 4809074: net, syscall: move multicast address handling

net, syscall: move multicast address handling

Multicast address handling is not consistent across all BSDs. Move
the multicast address handling code into OS dependent files. This
will be needed for OpenBSD support.

[jsing, 2011-08-10 15:52:03]

Hello mikioh.mikioh@gmail.com, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-08-10 16:30:15]

LGTM.

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_darwin.go
File src/pkg/syscall/route_darwin.go (right):

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_darwin....
src/pkg/syscall/route_darwin.go:13: const rtaIfmaMask = RTA_GATEWAY | RTA_IFP |
RTA_IFA
please move this const to just above sockaddr func.

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_freebsd.go
File src/pkg/syscall/route_freebsd.go (right):

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_freebsd...
src/pkg/syscall/route_freebsd.go:13: const rtaIfmaMask = RTA_GATEWAY | RTA_IFP |
RTA_IFA
please move this const to just above sockaddr func.

[jsing, 2011-08-10 16:43:39]

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_darwin.go
File src/pkg/syscall/route_darwin.go (right):

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_darwin....
src/pkg/syscall/route_darwin.go:13: const rtaIfmaMask = RTA_GATEWAY | RTA_IFP |
RTA_IFA
On 2011/08/10 16:30:16, mikioh wrote:
> please move this const to just above sockaddr func.

Done.

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_freebsd.go
File src/pkg/syscall/route_freebsd.go (right):

http://codereview.appspot.com/4809074/diff/2002/src/pkg/syscall/route_freebsd...
src/pkg/syscall/route_freebsd.go:13: const rtaIfmaMask = RTA_GATEWAY | RTA_IFP |
RTA_IFA
On 2011/08/10 16:30:16, mikioh wrote:
> please move this const to just above sockaddr func.

Done.

[rsc, 2011-08-16 21:27:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=ea636dacef9e ***

net, syscall: move multicast address handling

Multicast address handling is not consistent across all BSDs. Move
the multicast address handling code into OS dependent files. This
will be needed for OpenBSD support.

R=mikioh.mikioh, golang-dev
CC=golang-dev
http://codereview.appspot.com/4809074

Committer: Russ Cox <rsc@golang.org>