Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 4809051: Makes parameters for hairpin rotation available in Scheme (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by MikeSol
Modified:
12 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Patch Set 1 : Adds property callbacks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -7 lines) Patch
M lily/beam.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M lily/hairpin.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M lily/include/beam.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/new-dynamic-engraver.cc View 6 chunks +49 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 2 chunks +3 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
MikeSol
I think that this is sufficient to "fix" issue 36. As Graham points out in ...
12 years, 9 months ago (2011-07-23 14:48:01 UTC) #1
pkx166h
Make passes but reg test check fails see my comment: http://code.google.com/p/lilypond/issues/detail?id=36#c5
12 years, 9 months ago (2011-07-24 09:34:54 UTC) #2
Neil Puttock
On 23 July 2011 15:48, <mtsolo@gmail.com> wrote: > (a) is currently impossible to calculate in ...
12 years, 9 months ago (2011-07-24 21:29:10 UTC) #3
mike_apollinemike.com
On Jul 24, 2011, at 11:29 PM, Neil Puttock wrote: > On 23 July 2011 ...
12 years, 9 months ago (2011-07-25 08:03:12 UTC) #4
Graham Percival
On Mon, Jul 25, 2011 at 09:17:53AM +0200, mike@apollinemike.com wrote: > > We may want ...
12 years, 9 months ago (2011-07-25 22:22:05 UTC) #5
MikeSol
12 years, 9 months ago (2011-07-27 08:44:51 UTC) #6
On 2011/07/25 22:22:05, graham_percival-music.ca wrote:
> On Mon, Jul 25, 2011 at 09:17:53AM +0200, mailto:mike@apollinemike.com
> wrote:
> > 
> > We may want to just fix issue 36 via something in the docs-
> ...
> >  but as there is no clear way to
> > deal with these collisions, perhaps a section in the
> > documentation "Dealing with collisions" that says something to
> > the effect of "LilyPond does its best to avoid collisions
> > between objects.  However, often there is more than one solution
> > available to collision avoidance - white out, moving, rotating,
> > etc..
> 
> sounds good to me.  That's in Learning 4.5 Collisions of objects,
> right?
> 
> Cheers,
> - Graham

Yup.
I'm gonna close this Rietveld issue.  Could you downgrade the priority of the
issue on the tracker to either medium or low (depending on what you think would
be appropriate) and add the right tags that show this needs to be a
documentation suggestion (not a code base fix).

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b