Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 4809048: [google] Remove some XPASS/XFAIL markers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by Diego Novillo
Modified:
13 years, 10 months ago
Reviewers:
CC:
gcc-patches_gcc.gnu.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M gcc/testsuite/gcc.dg/inline_3.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/inline_4.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c View 1 chunk +1 line, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/unroll_2.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/unroll_3.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/testsuite/gcc.dg/unroll_4.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/testsuite/gcc.target/i386/sse4_1-blendps.c View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c View 1 chunk +2 lines, -1 line 0 comments Download
M libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc View 1 chunk +0 lines, -1 line 0 comments Download
M libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc View 1 chunk +0 lines, -1 line 0 comments Download
M libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc View 1 chunk +0 lines, -1 line 0 comments Download
M libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1
Diego Novillo
13 years, 11 months ago (2011-07-21 16:30:56 UTC) #1
This patch removes a few XPASSes from the testsuite.

It also forces all the sse4_1-blendps* tests to compile with -O0.  At
the point of the latest merge from trunk (175879), these tests were
flaky when compiled with -march=pentium3 -mtune=pentium4 -m32.

We were discussing this on IRC, and Jakub could not reproduce with a
recent trunk, so I expect this will be fixed by the next merge.


Diego.

gcc/testsuite/ChangeLog.google-integration
2011-07-21   Diego Novillo  <dnovillo@google.com>

	* gcc.dg/inline_3.c: Remove dg-excess-errors.
	* gcc.dg/inline_4.c: Likewise.
	* gcc.dg/unroll_2.c: Likewise.
	* gcc.dg/unroll_3.c: Likewise.
	* gcc.dg/unroll_4.c: Likewise.
	* gcc.dg/tree-ssa/20030807-7.c: Remove xfail.
	* gcc.target/i386/sse4_1-blendps-2.c: Compile with -O0.  Add FIXME note.
	* gcc.target/i386/sse4_1-blendps.c: Likewise.

libstdc++-v3/ChangeLog.google-integration:
	* testsuite/23_containers/vector/requirements/dr438/assign_neg.cc:
	Remove dg-excess-errors.
	* testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc:
	Likewise.
	* testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc:
	Likewise.
	* testsuite/23_containers/vector/requirements/dr438/insert_neg.cc:
	Likewise.

diff --git a/gcc/testsuite/gcc.dg/inline_3.c b/gcc/testsuite/gcc.dg/inline_3.c
index 17871c6..0b9ffed 100644
--- a/gcc/testsuite/gcc.dg/inline_3.c
+++ b/gcc/testsuite/gcc.dg/inline_3.c
@@ -20,4 +20,3 @@ int foo2 (void)
 
 /* { dg-final { scan-tree-dump-times "bar" 5 "optimized" } } */
 /* { dg-final { cleanup-tree-dump "optimized" } } */
-/* { dg-excess-errors "extra notes" } */
diff --git a/gcc/testsuite/gcc.dg/inline_4.c b/gcc/testsuite/gcc.dg/inline_4.c
index 1feefa1..a2fcac4 100644
--- a/gcc/testsuite/gcc.dg/inline_4.c
+++ b/gcc/testsuite/gcc.dg/inline_4.c
@@ -20,4 +20,3 @@ int foo2 (void)
 
 /* { dg-final { scan-tree-dump-times "bar" 4 "optimized" } } */
 /* { dg-final { cleanup-tree-dump "optimized" } } */
-/* { dg-excess-errors "extra notes" } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c
b/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c
index ed6f7c0..f9f5fb7 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c
@@ -33,5 +33,5 @@ simplify_condition (cond_p)
 }
 
 /* There should be exactly one IF conditional.  */
-/* { dg-final { scan-tree-dump-times "if " 1 "vrp1" { xfail *-*-* } } } */
+/* { dg-final { scan-tree-dump-times "if " 1 "vrp1" } } */
 /* { dg-final { cleanup-tree-dump "vrp1" } } */
diff --git a/gcc/testsuite/gcc.dg/unroll_2.c b/gcc/testsuite/gcc.dg/unroll_2.c
index 12912cf..9fdec57 100644
--- a/gcc/testsuite/gcc.dg/unroll_2.c
+++ b/gcc/testsuite/gcc.dg/unroll_2.c
@@ -30,4 +30,3 @@ int foo2(void)
 
 /* { dg-final { scan-rtl-dump-times "Decided to peel loop completely" 1
"loop2_unroll" } } */
 /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
diff --git a/gcc/testsuite/gcc.dg/unroll_3.c b/gcc/testsuite/gcc.dg/unroll_3.c
index d86ed55..cc9a4fb 100644
--- a/gcc/testsuite/gcc.dg/unroll_3.c
+++ b/gcc/testsuite/gcc.dg/unroll_3.c
@@ -30,4 +30,3 @@ int foo2(void)
 
 /* { dg-final { scan-rtl-dump-times "Decided to peel loop completely" 1
"loop2_unroll" } } */
 /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
diff --git a/gcc/testsuite/gcc.dg/unroll_4.c b/gcc/testsuite/gcc.dg/unroll_4.c
index 7c70157..4484f04 100644
--- a/gcc/testsuite/gcc.dg/unroll_4.c
+++ b/gcc/testsuite/gcc.dg/unroll_4.c
@@ -30,4 +30,3 @@ int foo2(void)
 
 /* { dg-final { scan-rtl-dump-times "Decided to peel loop completely" 1
"loop2_unroll" } } */
 /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
diff --git a/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c
b/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c
index b66bbfd..d8f4a46 100644
--- a/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c
+++ b/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c
@@ -1,6 +1,7 @@
 /* { dg-do run } */
 /* { dg-require-effective-target sse4 } */
-/* { dg-options "-O2 -msse4.1" } */
+/* FIXME - Forced -O0.  This test is flaky as of trunk@175879.  */
+/* { dg-options "-O0 -msse4.1" } */
 
 #include "sse4_1-check.h"
 
diff --git a/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c
b/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c
index 6234ffb..f6824ad 100644
--- a/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c
+++ b/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c
@@ -1,5 +1,6 @@
 /* { dg-do run } */
 /* { dg-require-effective-target sse4 } */
+/* FIXME - Forced -O0.  This test is flaky as of trunk@175879.  */
 /* { dg-options "-O0 -msse4.1" } */
 
 #ifndef CHECK_H
diff --git
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc
index 6d226ba..53812d4 100644
---
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc
+++
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc
@@ -19,7 +19,6 @@
 
 // { dg-do compile }
 // { dg-error "no matching" "" { target *-*-* } 1173 }
-// { dg-excess-errors "" }
 
 #include <vector>
 
diff --git
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc
index 5cf3d52..7ac6ef0 100644
---
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc
+++
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc
@@ -19,7 +19,6 @@
 
 // { dg-do compile }
 // { dg-error "no matching" "" { target *-*-* } 1103 }
-// { dg-excess-errors "" }
 
 #include <vector>
 
diff --git
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc
index 6645556..436acae 100644
---
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc
+++
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc
@@ -19,7 +19,6 @@
 
 // { dg-do compile }
 // { dg-error "no matching" "" { target *-*-* } 1103 }
-// { dg-excess-errors "" }
 
 #include <vector>
 #include <utility>
diff --git
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc
index 6d46fa4..0aa9f16 100644
---
a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc
+++
b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc
@@ -19,7 +19,6 @@
 
 // { dg-do compile }
 // { dg-error "no matching" "" { target *-*-* } 1214 }
-// { dg-excess-errors "" }
 
 #include <vector>
 

--
This patch is available for review at http://codereview.appspot.com/4809048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b