Issue 4806058: move render target decls / defs to their own headers / srcs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4806058: move render target decls / defs to their own headers / srcs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bsalomon

Modified:
12 years, 9 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+454 lines, -374 lines)			Patch
M	gpu/include/GrDrawTarget.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
A	gpu/include/GrRenderTarget.h	View	1 chunk	+190 lines, -0 lines	0 comments	Download
M	gpu/include/GrTexture.h	View	3 chunks	+4 lines, -180 lines	0 comments	Download
A	gpu/src/GrGLRenderTarget.h	View	1 chunk	+103 lines, -0 lines	0 comments	Download
A	gpu/src/GrGLRenderTarget.cpp	View	1 chunk	+71 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLTexture.h	View	2 chunks	+2 lines, -86 lines	0 comments	Download
M	gpu/src/GrGLTexture.cpp	View	1 chunk	+1 line, -60 lines	0 comments	Download
A	gpu/src/GrRenderTarget.cpp	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	gpu/src/GrTexture.cpp	View	2 chunks	+17 lines, -45 lines	0 comments	Download
M	gyp/gpu.gyp	View	3 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3

bsalomon

12 years, 9 months ago (2011-07-29 15:13:48 UTC) #3

On 2011/07/29 15:11:23, TomH wrote:
> LGTM

Closed with r1995.