Fix 1770: revert caused a crash in displayLilyMusic.

Fix 1770: revert caused a crash in displayLilyMusic.

Handle the property names similar to OverrideProperty (i.e. first check grob-property-path and then grob-property to get the name of the property).

[Neil Puttock, 2011-07-20 14:23:21]

Hi Reinhold,

LGTM, though I wonder whether it'd be better just to junk 'grob-property and use
'grob-property-path exclusively.

Cheers,
Neil

http://codereview.appspot.com/4805043/diff/1/input/regression/display-lily-te...
File input/regression/display-lily-tests.ly (right):

http://codereview.appspot.com/4805043/diff/1/input/regression/display-lily-te...
input/regression/display-lily-tests.ly:222: \test "NOT A BUG" ##[ \oneVoice #]	%
resetting a bunch of properties
can you add some tests for nested properties too?

http://codereview.appspot.com/4805043/diff/1/scm/define-music-display-methods...
File scm/define-music-display-methods.scm (right):

http://codereview.appspot.com/4805043/diff/1/scm/define-music-display-methods...
scm/define-music-display-methods.scm:884: (properties      (if (pair?
property-path)
(properties (ly:music-property expr 'grob-property-path
                               (list (ly:music-property expr 'grob-property))))

(same for OverrideProperty)

http://codereview.appspot.com/4805043/diff/1/scm/define-music-display-methods...
scm/define-music-display-methods.scm:892: (if (and (pair? properties) (null?
(cdr properties)))
remove pair? check

[pkx166h, 2011-07-20 20:52:56]

Passes Make and reg tests

[Neil Puttock, 2011-07-21 17:47:24]

http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-meth...
File scm/define-music-display-methods.scm (right):

http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-meth...
scm/define-music-display-methods.scm:867: ;; nested properties are written
#'prop1 #'prop2:
we encourage users to use list syntax for overrides, so I'd prefer this to be
left as it is

[Reinhold, 2011-07-21 18:27:58]

http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-meth...
File scm/define-music-display-methods.scm (right):

http://codereview.appspot.com/4805043/diff/2002/scm/define-music-display-meth...
scm/define-music-display-methods.scm:867: ;; nested properties are written
#'prop1 #'prop2:
On 2011/07/21 17:47:24, Neil Puttock wrote:
> we encourage users to use list syntax for overrides, so I'd prefer this to be
> left as it is

Really? The NR (section 5.3.6 "Modifying alists" as well as 4.4.1 "Flexible
vertical spacing within systems") only gives examples of the form
#'staff-staff-spacing #'basic-distance... I didn't even know that the list
syntax was there, let alone that it is the syntax we are advocating.

[Neil Puttock, 2011-07-21 18:38:04]

On 21 July 2011 19:27,  <reinhold.kainhofer@gmail.com> wrote:

> Really? The NR (section 5.3.6 "Modifying alists" as well as 4.4.1
> "Flexible vertical spacing within systems") only gives examples of the
> form #'staff-staff-spacing #'basic-distance... I didn't even know that
> the list syntax was there, let alone that it is the syntax we are
> advocating.

Those are recent doc changes added by Joe.  If you look elsewhere,
you'll see that all nested overrides use list syntax (I converted all
the docs when I add the support back in 2008).

Cheers,
Neil

[Reinhold, 2011-07-22 12:49:01]

On 2011/07/21 18:38:04, Neil Puttock wrote:
> Those are recent doc changes added by Joe.  If you look elsewhere,
> you'll see that all nested overrides use list syntax (I converted all
> the docs when I add the support back in 2008).

Okay, I have changed that back and pushed to git master.