Issue 4802052: code review 4802052: goyacc: cleanups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4802052: code review 4802052: goyacc: cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by r

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

goyacc: cleanups - remove calls to print - make units compile again - make units.y closer to gofmt style

Patch Set 1 #

Patch Set 2 : diff -r d0ca8c76d2ad https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -85 lines)			Patch
	M	src/cmd/goyacc/goyacc.go	View		5 chunks	+10 lines, -10 lines	0 comments	Download
	M	src/cmd/goyacc/units.y	View		10 chunks	+79 lines, -75 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-22 07:52:16 UTC) #1

semicolons! On Jul 22, 2011, at 5:57 PM, dsymonds@golang.org wrote: > LGTM > > retro ...

13 years, 9 months ago (2011-07-22 07:58:38 UTC) #3

13 years, 9 months ago (2011-07-22 07:58:44 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=627c9b93bae9 ***

goyacc: cleanups
- remove calls to print
- make units compile again
- make units.y closer to gofmt style

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4802052

Expand All Messages | Collapse All Messages