Issue 4802046: code review 4802046: os: point readers at the exec package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4802046: code review 4802046: os: point readers at the exec package (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bradfitz

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, evan, rsc

Visibility:
Public.

Description

os: point readers at the exec package

Patch Set 1 #

Patch Set 2 : diff -r 122ea252305f https://go.googlecode.com/hg #

Patch Set 3 : diff -r 122ea252305f https://go.googlecode.com/hg #

Patch Set 4 : diff -r cac31e88ff15 https://go.googlecode.com/hg #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/os/exec_posix.go	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-07-20 18:07:14 UTC) #1

evan

Thanks, this would've been very helpful for me (I searched the docs for "subprocess" and ...

13 years, 9 months ago (2011-07-20 18:08:17 UTC) #2

bradfitz

13 years, 9 months ago (2011-07-20 18:38:21 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f2765b9aec9b ***

os: point readers at the exec package

R=golang-dev, evan, rsc
CC=golang-dev
http://codereview.appspot.com/4802046

Expand All Messages | Collapse All Messages