Issue 4801074: code review 4801074: go-charset: change ErrorString to NewError

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4801074: code review 4801074: go-charset: change ErrorString to NewError (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rog

Modified:
14 years, 11 months ago

Reviewers:

CC:
golang-nuts_googlegroups.com

Visibility:
Public.

Description

go-charset: change ErrorString to NewError also fix SetFinalizer call.

Patch Set 1 #

Patch Set 2 : diff -r e41f8f54300e https://go-charset.googlecode.com/hg #

Patch Set 3 : diff -r e41f8f54300e https://go-charset.googlecode.com/hg #

Patch Set 4 : diff -r e41f8f54300e https://go-charset.googlecode.com/hg #

Patch Set 5 : diff -r e41f8f54300e https://go-charset.googlecode.com/hg #

Patch Set 6 : diff -r e41f8f54300e https://go-charset.googlecode.com/hg #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	charset/charset.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	charset/iconv/iconv.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	charset/utf16.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rog

Hello golang-nuts@googlegroups.com, I'd like you to review this change to https://go-charset.googlecode.com/hg

14 years, 11 months ago (2011-08-03 12:17:45 UTC) #1

rog

14 years, 11 months ago (2011-08-13 14:41:32 UTC) #2

*** Submitted as
http://code.google.com/p/go-charset/source/detail?r=8361d69ca3f4 ***

go-charset: change ErrorString to NewError
also fix SetFinalizer call.

R=golang-nuts
http://codereview.appspot.com/4801074

Expand All Messages | Collapse All Messages