code review 4798042: gob: send empty but non-nil maps.

gob: send empty but non-nil maps.
Fixes issue 2082.

[r, 2011-07-20 06:54:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-07-20 07:05:17]

Do you also need to do the same thing for slices?

[r2, 2011-07-20 07:24:54]

On Jul 20, 2011, at 5:05 PM, David Symonds wrote:

> Do you also need to do the same thing for slices?

No, because they don't have the problem.

You can't write to either a nil map or a nil slice, but you can append to a nil
slice and that's what usually happens.

-rob

[dsymonds, 2011-07-20 07:32:01]

LGTM

modulo doc fix

http://codereview.appspot.com/4798042/diff/1/src/pkg/gob/doc.go
File src/pkg/gob/doc.go (right):

http://codereview.appspot.com/4798042/diff/1/src/pkg/gob/doc.go#newcode116
src/pkg/gob/doc.go:116: Maps are sent as an unsigned count followed by that man
key, element
"that man key"?

[r2, 2011-07-20 08:25:19]

man key good

On Wednesday, July 20, 2011,  <dsymonds@golang.org> wrote:
> LGTM
>
> modulo doc fix
>
>
> http://codereview.appspot.com/4798042/diff/1/src/pkg/gob/doc.go
> File src/pkg/gob/doc.go (right):
>
> http://codereview.appspot.com/4798042/diff/1/src/pkg/gob/doc.go#newcode116
> src/pkg/gob/doc.go:116: Maps are sent as an unsigned count followed by
> that man key, element
> "that man key"?
>
> http://codereview.appspot.com/4798042/
>

[r, 2011-07-21 00:27:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=ec21d1bbe91f ***

gob: send empty but non-nil maps.
Fixes issue 2082.

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/4798042