Issue 4794060: code review 4794060: ld: remove cseekend and redo pe writing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4794060: code review 4794060: ld: remove cseekend and redo pe writing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by brainman

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

ld: remove cseekend and redo pe writing Simplify code and add more checks. Fixes issue 2105.

Patch Set 2 : diff -r 46d1b5a6bced https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 46d1b5a6bced https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 46d1b5a6bced https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 854c7c44697c https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 8c0c8f7a5c0f https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -49 lines)			Patch
M	src/cmd/ld/lib.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/ld/lib.c	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/cmd/ld/pe.c	View	1 2 3 4	17 chunks	+51 lines, -42 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-27 06:27:35 UTC) #1

rsc

why doesn't the windows code know where the end of the file is?

13 years, 9 months ago (2011-07-27 16:02:54 UTC) #2

brainman

On 2011/07/27 16:02:54, rsc wrote: > why doesn't the windows code know > where the ...

13 years, 9 months ago (2011-07-28 00:07:52 UTC) #3

brainman

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 9 months ago (2011-07-28 02:31:42 UTC) #4

rsc

LGTM http://codereview.appspot.com/4794060/diff/4004/src/cmd/ld/pe.c File src/cmd/ld/pe.c (right): http://codereview.appspot.com/4794060/diff/4004/src/cmd/ld/pe.c#newcode344 src/cmd/ld/pe.c:344: addexports() (void)

13 years, 9 months ago (2011-07-28 03:12:17 UTC) #5

brainman

13 years, 9 months ago (2011-07-28 04:31:00 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=d34b31b7e93a ***

ld: remove cseekend and redo pe writing

Simplify code and add more checks.

Fixes issue 2105.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4794060

http://codereview.appspot.com/4794060/diff/4004/src/cmd/ld/pe.c
File src/cmd/ld/pe.c (right):

http://codereview.appspot.com/4794060/diff/4004/src/cmd/ld/pe.c#newcode344
src/cmd/ld/pe.c:344: addexports()
On 2011/07/28 03:12:17, rsc wrote:
> (void)

Done.

Expand All Messages | Collapse All Messages