Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 4794057: Add Notation appendix for context mod identifiers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Neil Puttock
Modified:
12 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add Notation appendix for context mod identifiers. * Documentation/notation/notation-appendices.itely: add node for context modifications * lily/context-mod.cc: add type predicate ly:context-mod? * ly/context-mods-init.ly (RemoveEmptyStaves): add docstring via \description * scm/document-context-mods.scm: new file for generating context-mod documentation * scm/document-identifiers.scm (identifier<?): move to documentation-lib.scm * scm/documentation-generate.scm: load document-context-mods.scm and output documentation to context-mod-identifiers.tely * scm/documentation-lib.scm (identifier<?): moved from document-identifiers.scm so it can be used in document-context-mods.scm too * scripts/auxiliar/ref_check.tely: exclude context-mod-identifiers.tely * scripts/build/website-known-missing-files.txt: add context-mod-identifiers.tely

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -7 lines) Patch
M Documentation/notation/notation-appendices.itely View 2 chunks +8 lines, -0 lines 0 comments Download
M lily/context-mod.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ly/context-mods-init.ly View 1 1 chunk +2 lines, -0 lines 0 comments Download
A scm/document-context-mods.scm View 1 chunk +100 lines, -0 lines 0 comments Download
M scm/document-identifiers.scm View 1 1 chunk +0 lines, -7 lines 0 comments Download
M scm/documentation-generate.scm View 2 chunks +4 lines, -0 lines 0 comments Download
M scm/documentation-lib.scm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/auxiliar/ref_check.tely View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/build/website-known-missing-files.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Neil Puttock
Hello, This patch adds auto-generated documentation for context modifications (currently, only \RemoveEmptyStaves). Any context modification ...
12 years, 9 months ago (2011-07-23 20:18:52 UTC) #1
pkx166h
Passes make and reg tests. James
12 years, 9 months ago (2011-07-24 10:06:15 UTC) #2
Graham Percival (old account)
LGTM, fantastic work as always.
12 years, 8 months ago (2011-08-03 20:06:49 UTC) #3
Neil Puttock
12 years, 8 months ago (2011-08-07 14:27:25 UTC) #4
On 2011/08/03 20:06:49, Graham Percival wrote:
> LGTM, fantastic work as always.

Thanks!

Pushed: 33f71ee2c062b4e377e146920ef48ea8c41d6fe8

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b