Issue 4794052: code review 4794052: ld: fixes ldpe link with SXREF global values.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4794052: code review 4794052: ld: fixes ldpe link with SXREF global values. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by vcc

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, mattn, rsc

Visibility:
Public.

Description

ld: fixes ldpe link with SXREF global values.

Patch Set 1 #

Patch Set 2 : code review 4794052: ld: fixes ldpe link with SXREF global values. #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/ld/ldpe.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

vcc

Hello golang-dev@googlegroups.com, I'd like you to review this change.

12 years, 9 months ago (2011-07-22 05:58:38 UTC) #1

mattn

LGTM On 2011/07/22 05:58:38, vcc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to ...

12 years, 9 months ago (2011-07-22 06:59:29 UTC) #2

rsc

12 years, 9 months ago (2011-07-23 01:21:11 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d951e2a4e1bb ***

ld: fixes ldpe link with SXREF global values.

R=golang-dev, mattn.jp, rsc
CC=golang-dev
http://codereview.appspot.com/4794052

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages