Issue 4782042: code review 4782042: sync/atomic: fix LoadInt32 on ARM

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4782042: code review 4782042: sync/atomic: fix LoadInt32 on ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by dvyukov

Modified:
14 years, 8 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

sync/atomic: fix LoadInt32 on ARM R0 is clobbered after cas, while R1 preserves its value.

Patch Set 1 #

Patch Set 2 : diff -r f7c898383887 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f7c898383887 https://go.googlecode.com/hg/ #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/sync/atomic/asm_linux_arm.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 8 months ago (2011-07-19 12:06:23 UTC) #1

dvyukov

The code is also untested :( May somebody test it on an ARM device?

14 years, 8 months ago (2011-07-19 12:08:53 UTC) #2

14 years, 8 months ago (2011-07-19 12:10:14 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e5d2a3b18f7c ***

sync/atomic: fix LoadInt32 on ARM
R0 is clobbered after cas,
while R1 preserves its value.

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/4782042

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages