code review 4781042: html: handle character entities without semicolons

html: handle character entities without semicolons

Fix the TODO: unescape("&notit;") should be "¬it;"

Also accept digits in entity names.

[andybalholm, 2011-07-19 15:07:06]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
nigeltao@golang.org, rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-07-20 03:28:57]

http://codereview.appspot.com/4781042/diff/4001/src/pkg/html/escape.go
File src/pkg/html/escape.go (right):

http://codereview.appspot.com/4781042/diff/4001/src/pkg/html/escape.go#newcod...
src/pkg/html/escape.go:139: if entityName == "" {
Replace the if-else-if chain with a switch statement.

http://codereview.appspot.com/4781042/diff/4001/src/pkg/html/escape.go#newcod...
src/pkg/html/escape.go:140: 
Write "// No-op." for a no-op case, instead of a blank line.

http://codereview.appspot.com/4781042/diff/4001/src/pkg/html/escape.go#newcod...
src/pkg/html/escape.go:151: maxLen = 6 // None of the entities that doesn't end
with ';' is longer than 6 bytes.
The 6 should be a named constant (in entity.go), and verify this assertion in
entity_test.go.

[andybalholm, 2011-07-20 14:36:01]

Hello golang-dev@googlegroups.com, nigeltao@golang.org (cc:
golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[andybalholm, 2011-07-20 14:36:21]

Hello golang-dev@googlegroups.com, nigeltao@golang.org (cc:
golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[nigeltao, 2011-07-20 22:47:25]

http://codereview.appspot.com/4781042/diff/12001/src/pkg/html/entity.go
File src/pkg/html/entity.go (right):

http://codereview.appspot.com/4781042/diff/12001/src/pkg/html/entity.go#newcode7
src/pkg/html/entity.go:7: const longestEntityWithoutSemicolon = 6
Add a comment:
// All entities that do not end with ';' are 6 or fewer bytes long.

http://codereview.appspot.com/4781042/diff/12001/src/pkg/html/token_test.go
File src/pkg/html/token_test.go (right):

http://codereview.appspot.com/4781042/diff/12001/src/pkg/html/token_test.go#n...
src/pkg/html/token_test.go:112: `&notit;&notin;<a b="q=z&amp=5&notice=hello">`,
Please change "hello" to "hello&not;=world", and on the next line this becomes
"hello¬=world".

[nigeltao, 2011-07-20 23:00:06]

http://codereview.appspot.com/4781042/diff/12001/src/pkg/html/escape.go
File src/pkg/html/escape.go (right):

http://codereview.appspot.com/4781042/diff/12001/src/pkg/html/escape.go#newco...
src/pkg/html/escape.go:146: x := entity[entityName]
Ugh, I didn't realize that you'd have to look up the entity map twice.

Please change it back to an if-else-if chain. Sorry to waste your time.

[andybalholm, 2011-07-20 23:04:50]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[nigeltao, 2011-07-20 23:08:46]

LGTM, thanks.

And by "LGTM", I mean the code, not HTML5. Ugh!

[nigeltao, 2011-07-20 23:11:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=ba2e1d04d77b ***

html: handle character entities without semicolons

Fix the TODO: unescape("&notit;") should be "¬it;"

Also accept digits in entity names.

R=nigeltao
CC=golang-dev, rsc
http://codereview.appspot.com/4781042

Committer: Nigel Tao <nigeltao@golang.org>