code review 4766042: runtime: add per-M caches for MemStats

runtime: add per-M caches for MemStats
Avoid touching centralized state during
memory manager operations.

[dvyukov, 2011-07-18 18:47:27]

Hello rsc@golang.com, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dvyukov, 2011-07-18 18:49:34]

Some tests get broken as expected. I had to add calls to runtime.GC() into some
tests. runtime.GC() now represents a method to say "I need up-to-date memory
statistics now".

[rsc, 2011-07-18 18:50:44]

LGTM

Thanks.

http://codereview.appspot.com/4766042/diff/17006/src/pkg/runtime/malloc.h
File src/pkg/runtime/malloc.h (right):

http://codereview.appspot.com/4766042/diff/17006/src/pkg/runtime/malloc.h#new...
src/pkg/runtime/malloc.h:271: int64 local_alloc;	// bytes allocated and still in
use since last lock of heap
s/and still in use/(or freed)/
like the other comments

[rsc, 2011-07-18 18:53:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=a7eaa59037d4 ***

runtime: add per-M caches for MemStats
Avoid touching centralized state during
memory manager opreations.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4766042

Committer: Russ Cox <rsc@golang.org>

[aam, 2011-07-18 18:53:23]

> Description:
> runtime: add per-M caches for MemStats
> Avoid touching centralized state during
> memory manager opreations.


should be "operations"

[dvyukov, 2011-07-18 18:53:44]

Hello mirtchovski@gmail.com (cc: golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[dvyukov, 2011-07-18 18:56:01]

On 2011/07/18 18:53:23, aam wrote:
> > Description:
> > runtime: add per-M caches for MemStats
> > Avoid touching centralized state during
> > memory manager opreations.
> 
> 
> should be "operations"

Done.

[rsc, 2011-07-18 18:56:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=00f0d6062b5d ***

runtime: add per-M caches for MemStats
Avoid touching centralized state during
memory manager operations.

R=mirtchovski
CC=golang-dev, rsc
http://codereview.appspot.com/4766042

Committer: Russ Cox <rsc@golang.org>