code review 4761044: exp/template: allow declaration of variables only insid...

exp/template: allow declaration of variables only inside control structures.
In simple pipelines the declaration has no scope.
Also document the scope.

[r, 2011-07-17 01:28:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-17 01:30:57]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-07-17 01:33:59]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-07-17 01:53:56]

LGTM

http://codereview.appspot.com/4761044/diff/7001/src/pkg/exp/template/doc.go
File src/pkg/exp/template/doc.go (right):

http://codereview.appspot.com/4761044/diff/7001/src/pkg/exp/template/doc.go#n...
src/pkg/exp/template/doc.go:156: A pipeline inside an "if", "with", or "range"
may initialize a single variable
range may initialise two variables.

[r, 2011-07-17 02:32:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=bf35e2f208cb ***

exp/template: allow declaration of variables only inside control structures.
In simple pipelines the declaration has no scope.
Also document the scope.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4761044

[rsc, 2011-07-18 14:02:14]

LGTM