Issue 4759051: code review 4759051: gif: fix local color map and coordinates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4759051: code review 4759051: gif: fix local color map and coordinates (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by r

Modified:
13 years, 9 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

gif: fix local color map and coordinates

Patch Set 2 : diff -r d208aa10a3e7 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
	M	src/pkg/image/gif/reader.go	View	1	5 chunks	+19 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello nigeltao (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-18 05:54:21 UTC) #1

nigeltao

LGTM. http://codereview.appspot.com/4759051/diff/1/src/pkg/image/gif/reader.go File src/pkg/image/gif/reader.go (right): http://codereview.appspot.com/4759051/diff/1/src/pkg/image/gif/reader.go#newcode31 src/pkg/image/gif/reader.go:31: ifLocalColorTable = 1 << 7 Run gofmt.

13 years, 9 months ago (2011-07-18 07:48:27 UTC) #2

13 years, 9 months ago (2011-07-19 01:47:22 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=82f2dba2f74c ***

gif: fix local color map and coordinates

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/4759051

Expand All Messages | Collapse All Messages