code review 4758051: path/filepath: fixes for windows paths

path/filepath: fixes for windows paths

- Clean and IsAbs to handle paths with drive letter properly.
- Clean to replace / with \.

[brainman, 2011-07-18 04:46:11]

Hello golang-dev@googlegroups.com (cc: mattn.jp@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-18 06:01:29]

LGTM

http://codereview.appspot.com/4758051/diff/3005/src/pkg/go/scanner/scanner_te...
File src/pkg/go/scanner/scanner_test.go (right):

http://codereview.appspot.com/4758051/diff/3005/src/pkg/go/scanner/scanner_te...
src/pkg/go/scanner/scanner_test.go:472: segments = append(segments,
unixsegments...)
again, use a function-scoped variable instead.

http://codereview.appspot.com/4758051/diff/3005/src/pkg/path/filepath/path_te...
File src/pkg/path/filepath/path_test.go (right):

http://codereview.appspot.com/4758051/diff/3005/src/pkg/path/filepath/path_te...
src/pkg/path/filepath/path_test.go:71: {`c:`, `c:.`},
This behavior seems arbitrary. What's the rationale? Not saying it's wrong; just
curious.

http://codereview.appspot.com/4758051/diff/3005/src/pkg/path/filepath/path_te...
src/pkg/path/filepath/path_test.go:86: cleantests = append(cleantests,
wincleantests...)
Use a function-scoped variable here instead of modifying the global. Doesn't
matter in this case but it's good practice.

[brainman, 2011-07-18 07:08:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=c32724dcea9d ***

path/filepath: fixes for windows paths

- Clean and IsAbs to handle paths with drive letter properly.
- Clean to replace / with \.

R=golang-dev, adg
CC=golang-dev, mattn.jp
http://codereview.appspot.com/4758051

http://codereview.appspot.com/4758051/diff/3005/src/pkg/go/scanner/scanner_te...
File src/pkg/go/scanner/scanner_test.go (right):

http://codereview.appspot.com/4758051/diff/3005/src/pkg/go/scanner/scanner_te...
src/pkg/go/scanner/scanner_test.go:472: segments = append(segments,
unixsegments...)
On 2011/07/18 06:01:29, adg wrote:
> again, use a function-scoped variable instead.

Done.

http://codereview.appspot.com/4758051/diff/3005/src/pkg/path/filepath/path_te...
File src/pkg/path/filepath/path_test.go (right):

http://codereview.appspot.com/4758051/diff/3005/src/pkg/path/filepath/path_te...
src/pkg/path/filepath/path_test.go:71: {`c:`, `c:.`},
On 2011/07/18 06:01:29, adg wrote:
> This behavior seems arbitrary. What's the rationale? ...

All wincleantests (bar last) are just repeats of some cleantests with "c:" drive
letter in front. These are to test Clean for windows specific paths, the ones
that have drive letter included.

http://codereview.appspot.com/4758051/diff/3005/src/pkg/path/filepath/path_te...
src/pkg/path/filepath/path_test.go:86: cleantests = append(cleantests,
wincleantests...)
On 2011/07/18 06:01:29, adg wrote:
> Use a function-scoped variable here instead of modifying the global. Doesn't
> matter in this case but it's good practice.

Done.