Issue 4757047: code review 4757047: exp/template: dig into empty interfaces so a struct (sa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4757047: code review 4757047: exp/template: dig into empty interfaces so a struct (sa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by r

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

exp/template: dig into empty interfaces so a struct (say) stored in an empty interface field can be unpacked. We don't have type assertions here so we must be forthright.

Patch Set 1 #

Patch Set 2 : diff -r a9bf9aafff7a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 03a73e707c17 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	src/pkg/exp/template/exec.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
	M	src/pkg/exp/template/exec_test.go	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-07-18 06:54:00 UTC) #1

13 years, 9 months ago (2011-07-18 07:34:48 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8d9d4ba84d99 ***

exp/template: dig into empty interfaces so a struct (say) stored in an empty
interface field can be unpacked. We don't have type assertions here so we
must be forthright.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4757047

Expand All Messages | Collapse All Messages